Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/optimize: add march=native to host cflags #3068

Merged
merged 1 commit into from
Nov 4, 2018

Conversation

antonlacon
Copy link
Contributor

This makes the assumption that the machine that will build the host tools will also be the machine to use them, and therefore march=native will produce valid instructions. Decreases time to build an image for me by slightly over 5 minutes (-3.4%)

Relies on the assumption that the machine that will build the toolchain will
also be the machine to use said toolchain.

Signed-off-by: Ian Leonard <antonlacon@gmail.com>
@CvH
Copy link
Member

CvH commented Oct 31, 2018

jenkins was happy at all archs

@MilhouseVH
Copy link
Contributor

I did more testing with and without #3068

With PR3068:

02h35m04s: 100.00% complete [pi1-testing: log.job1] * BUILD SUCCESSFUL!
02h32m53s: 100.00% complete [pi2-testing: log.job2] * BUILD SUCCESSFUL!
03h02m40s: 100.00% complete [x86-testing: log.job3] * BUILD SUCCESSFUL!

02h32m22s: 100.00% complete [pi1-testing: log.job1] * BUILD SUCCESSFUL!
02h33m15s: 100.00% complete [pi2-testing: log.job2] * BUILD SUCCESSFUL!
03h04m22s: 100.00% complete [x86-testing: log.job3] * BUILD SUCCESSFUL!

02h33m44s: 100.00% complete [pi1-testing: log.job1] * BUILD SUCCESSFUL!
02h35m02s: 100.00% complete [pi2-testing: log.job2] * BUILD SUCCESSFUL!
03h06m10s: 100.00% complete [x86-testing: log.job3] * BUILD SUCCESSFUL!

Without PR3068:

02h35m22s: 100.00% complete [pi1-testing: log.job1] * BUILD SUCCESSFUL!
02h34m39s: 100.00% complete [pi2-testing: log.job2] * BUILD SUCCESSFUL!
03h06m43s: 100.00% complete [x86-testing: log.job3] * BUILD SUCCESSFUL!

02h31m59s: 100.00% complete [pi1-testing: log.job1] * BUILD SUCCESSFUL!
02h33m00s: 100.00% complete [pi2-testing: log.job2] * BUILD SUCCESSFUL!
03h11m09s: 100.00% complete [x86-testing: log.job3] * BUILD SUCCESSFUL!

02h32m02s: 100.00% complete [pi1-testing: log.job1] * BUILD SUCCESSFUL!
02h33m21s: 100.00% complete [pi2-testing: log.job2] * BUILD SUCCESSFUL!
03h07m35s: 100.00% complete [x86-testing: log.job3] * BUILD SUCCESSFUL!

So the "With PR3068" Generic builds tended to be a little faster than "without", while RPi/RPi2 builds were about the same as "without" (maybe even a little slower). Not really conclusive, and certainly not an issue.

Test build server: Intel Haswell 4GHz with 8 cores.

@MilhouseVH MilhouseVH merged commit 221c7a1 into LibreELEC:master Nov 4, 2018
@antonlacon antonlacon deleted the assume-host-builder branch November 8, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants