Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: use project specific cputemp scripts for all projects #3077

Merged
merged 1 commit into from
Nov 11, 2018
Merged

kodi: use project specific cputemp scripts for all projects #3077

merged 1 commit into from
Nov 11, 2018

Conversation

MilhouseVH
Copy link
Contributor

@MilhouseVH MilhouseVH commented Nov 2, 2018

  1. All projects other than RPi and Rockchip use the cputemp/gputemp setting in Kodi advancedsettings.xml. This means that RPi (and potentially Rockchip) are at the mercy of Kodi to get it right (which doesn't always happen: see cputemp: give RPi SoC sensor priority #3073)

    With this PR, all projects now use the cputemp and gputemp scripts.

  2. The current cputemp script includes logic for all platforms, even old kernels. This is unnecessary when most platforms and kernels use only a single path for the CPU temp.

    With this PR, all projects now use only the path(s) necessary to return the CPU temp for the current kernel.

This means that Amlogic (and possibly others) will need to amend this script when using the mainline kernel. Allwinner - which apparently has a gpu temp sensor - may need to differentiate between cputemp and gputemp based on the script name (see Generic version for details).

Please can the various project maintainers check that I have used the correct /sysfs path for the CPU temperature sensor (based on current LE master kernels). Thanks.

  • RPi
  • Generic
  • Rockchip (same as RPi)
  • Amlogic (3.10/3.14)
  • WeTek_Core
  • WeTek_Play

@MilhouseVH
Copy link
Contributor Author

Shall we merge this? Any broken platforms can fix themselves.

@CvH CvH merged commit fa55839 into LibreELEC:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants