buildsystem: unpacking / extracting cleanup

[antonlacon]

I was looking at adjusting PKG_BUILD and came across these cleanups. There shouldn't be anything exciting in here. This replaces a few places that should be using PKG_BUILD too. To ease looking it up, PKG_BUILD is defined in config/path: https://github.com/LibreELEC/LibreELEC.tv/blob/master/config/path#L132

Tested with an RPi build.

[MilhouseVH]

Thanks for this, looks good - just a few minors/suggestions.

[antonlacon]

These should be adjusted for, and a couple quotes and the printf -> die message in unpack.

[MilhouseVH]

Thanks for this cleanup.

One minor (additional) suggestion - in scripts/extract, how would you feel about splitting:

[ ! -d "$SOURCES/$1" -o ! -d "$2" ] && die "$PKG_NAME: $SOURCES/$1 not found"

into

[ ! -d "$SOURCES/$1" ] && die "$PKG_NAME: source $SOURCES/$1 not found"
[ ! -d "$2" ] && die "$PKG_NAME: target $2 not found"

?

[MilhouseVH]

Although I'm happy to remove $SED, since it's currently used in 15 packages it might be better to address that in a separate PR, where we can apply any missing -e -i options as required.

[antonlacon]

Test split, errant ";" removed and echo to replace printf most places. The spot in config/functions where it's used with awk needs confirmation; it looks straight forward, but I don't use awk.

And $SED -> sed in build.

[MilhouseVH]

Looks good to me, thanks. Unless any objections/additions I'd say we can merge this in the next day or so. I'll include in my test builds as well.