-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildsystem: add possibility to move the build paths outside the git … #3140
Conversation
This is ridiculous. Just put whole LE on this faster disk and you are done. Seems LE is folowing Kodi development path lately: "let's change things just because we can". |
Does PR3147 meet your needs? |
My special needs/requirements are taking care with my own build. But I don't push them to LE just to make my life easier. There are lot of commits lately which would not be even considered to be included few years back. But who am I to judge. Seems messing with build system must be really fun :) Even if not broken. |
While I do agree this requirement is niche, it is consistent with previous changes (see #2348), so I would be inclined to accept this change but possibly not in the current form - I'd suggest introducing a This means in
and then in
As an aside, I'm really not sure what value there is in
|
Note that @antonlacon has identified some other areas where |
I take a look, to adjust the change. I will compare to I am a bit paranoid, after a disk crash and use only backuped or raids for working paths. These are slow, but more protected. But all run/build-paths on fast constructions. |
39b08d6
to
398b6ba
Compare
71e820e
to
6cdd3ca
Compare
@MilhouseVH i switchted to your |
42ebe14
to
4bd4f58
Compare
@@ -1,5 +1,6 @@ | |||
# build directorys | |||
/build.*/ | |||
/builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope. possible name for a symlink to right location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What symlink? AFAICS nothing uses /builds
and this patch gets rid of the need to symlink anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you moved the build-root outside, you may want to access it fast.
so a symlink builds
to the new location will be fine ;)
The |
this will be difficult: because we do not know, if we can delete all at the new location. |
I don't know why this should be ridiculous, but I'm using this ;) Usecase: fast box with lots of RAM and just a SSD. Building the whole of LE on that doesn't exactly go easy on the drive and wears it out too fast. So I build it on a 30gb ramdisk. And no, I don't want to move my git tree there ;) |
Good point. Overall, this fits in nicely with e.g. |
Let's see what breaks... 😄 |
…tree
builds can be placed on different (faster) disk.
The normal behavior unchanged. To change the path only add
BUILD_ROOT=/build-dev
in your.libreelec/options
For use with multiple git-workspaces
BUILD_ROOT=/build-dev/$(basename $ROOT)
is better.tested with: generic & rpi2 builds (incl. all addons)