Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvheadend42: update #3162

Closed
wants to merge 1 commit into from
Closed

tvheadend42: update #3162

wants to merge 1 commit into from

Conversation

CvH
Copy link
Member

@CvH CvH commented Dec 11, 2018

  • fixes xmltv urls like http://xmltv.tv/script.php?username=123&password=1234&type=m3u_plus
    if you enter & at Kodi it get rewritten to & - that change inline replaces it

ping @edit4ever @TheUlpio maybe you have some opinion about

  • other updates are following (just pushed the xmltv change to get some feedback at the moment)

@edit4ever
Copy link
Collaborator

Since I use my own grabber - I haven't experienced the issue that @CvH is fixing. However I am running his latest Tvh build on my RPi3 and everything is working well. So for me, adding fixes that move closer to the latest build would seem ok.
If there is a specific function you would like me to test - let me know.

@MilhouseVH
Copy link
Contributor

Close this, as fixed by 324394a ?

@CvH
Copy link
Member Author

CvH commented Jan 12, 2019

uhh forgot this one, yes superseded by #3164

@rkershenbaum
Copy link

The fix for urls containing ampersands ("&") seems to have dropped out of the current source. That breaks EPG downloading when a password is required in the url.

@CvH
Copy link
Member Author

CvH commented May 21, 2019

The fix for urls containing ampersands ("&") seems to have dropped out of the current source

so it doesn't work for 9.0.2 anymore ?? wondering because the fix is still there

@rkershenbaum
Copy link

It stopped working for me when I upgraded to LibreELEC 9.0.2. I don't see the fix in the source code anymore. It should be at line 40 here:

https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/addons/service/tvheadend42/source/bin/tv_grab_file

On my system, I changed that line to:

wget -qO - $(xml unesc $XMLTV_LOCATION_WEB)

...and it started working again.

Or am I missing something?

@CvH
Copy link
Member Author

CvH commented May 21, 2019

Or am I missing something?

324394a#diff-185e97999ddc3092656bdd5250a3b5b0 thats the fix for it, and it worked (I tested your url etc)

you can pm me the url again if you like, maybe be accidentally dropped something at an other place :D

@rkershenbaum
Copy link

rkershenbaum commented May 21, 2019 via email

@CvH
Copy link
Member Author

CvH commented May 21, 2019

ok, good to hear :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants