-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plymouth-lite: add bilinear interpolation patch #353
Conversation
Might be worth timing this on a slow platform like Pi 1. |
@popcornmix You are correct, it is quite expensive on Pi 1, running with
|
There is an alternative to this.
Should get you a resized splash screen using high quality (cubic) hardware resizing, and will be much faster. |
Thanks, I will change frame buffer size to match image in RasPlex.
|
Using a A |
Yes, I think so - you could be forcing the framebuffer to a resolution the display/monitor doesn't support, which would either fail (leaving you with the default resolution, which may require scaling) or worst case no working display/frame buffer at all. I think if bilinear resizing is too slow on low-end hardware then it shouldn't be used, ie. disable at compile time. |
On Pi forcing fbset framebuffer to match the size of the splash should be fine. |
any updates here? |
Has this been tweaked to avoid performance issues on pi and is a safe/good thing to merge? ..or? |
After #381 is this still required? After reviewing the earlier conversation, one thing I notice is that if I can PR this change if kwiboo requires it, otherwise setting |
It is possible that #381 will solve my resize issue but I haven't had time to test it out yet. The rasplelx distro due to be released next week is based on libreelec-7.0 where I use the patch from this PR together with a custom We can close this PR for now, I will revisit this once I rebase our distro on master. |
This PR should enhance boot splash image resize quality (makes our RasPlex boot splash look better when resized)