Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: update to 5.7.12 #366

Merged
merged 1 commit into from
Jun 1, 2016
Merged

mysql: update to 5.7.12 #366

merged 1 commit into from
Jun 1, 2016

Conversation

lrusak
Copy link
Member

@lrusak lrusak commented May 19, 2016

mysql 5.7.12 needs the exact boost version 1_59_0. So downgrading boost is the simplest solution.

mysql 5.7 bring tls 1.2 encryption.

@MilhouseVH a clean build with this would be appreciated.

@lrusak
Copy link
Member Author

lrusak commented May 20, 2016

Updated, thanks for testing @MilhouseVH 👍

@vpeter4
Copy link
Contributor

vpeter4 commented May 20, 2016

It is possible to instruct mysql 5.7.12 to download correct boost version when building.

@lrusak
Copy link
Member Author

lrusak commented May 20, 2016

@vpeter4 yes it is, however this is a lot of extra bandwidth when you have to build all the projects :)

@vpeter4
Copy link
Contributor

vpeter4 commented May 20, 2016

Agree. If boost on a system will need to upgrade back then for mysql should be used different solution.
Because I was rebuilding this few times I download the package once and unpack the content to required folder.

@stefansaraev
Copy link
Contributor

what if something else needs "exact" boost 1.58.0 tomorrow?

doesnt this work ? : -DDOWNLOAD_BOOST=1 -DWITH_BOOST=$ROOT/$PKG_BUILD/boost_build

@vpeter4
Copy link
Contributor

vpeter4 commented May 20, 2016

Yes, downloading boost works from mysql itself.

@stefansaraev
Copy link
Contributor

so, mysql now requires boost for a feature you wont ever use (GIS). why not use 5.5 or 5.6 instead ?

@lrusak
Copy link
Member Author

lrusak commented May 20, 2016

because tls 1.2
http://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-10.html

as requested by users

@stefansaraev
Copy link
Contributor

what's the benefit of using tls in your local network ?

@lrusak
Copy link
Member Author

lrusak commented May 20, 2016

maybe they want some shared cloud mysql database. who knows 😄

@stefansaraev
Copy link
Contributor

so TLSv1 that is available in 5.6 is not enough?

@MilhouseVH
Copy link
Contributor

The boost dependency is unfortunate but is this likely to be a problem when the trend is to move away from boost? A quick scan shows only mpd with a boost dependency, and mpd should be able to use 1_59_0.

@sopparus
Copy link
Contributor

since boost is only used for GIS it would be safe to make mysql ignore the 1.59 check and compile with 1.60. I have tried that and it works. (just an option)

@lrusak
Copy link
Member Author

lrusak commented May 20, 2016

thanks @sopparus . I have dropped the boost commit and updated mysql to work with boost 1_60_0


PKG_CONFIGURE_OPTS_HOST="--with-zlib-dir=$ROOT/$TOOLCHAIN"
sed -i "s|BOOST_MINOR_VERSION EQUAL 59|BOOST_MINOR_VERSION EQUAL 60|" $ROOT/$PKG_BUILD/cmake/boost.cmake
Copy link
Contributor

@stefansaraev stefansaraev May 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sed -i '/^IF(NOT BOOST_MINOR_VERSION.*$/,/^ENDIF()$/d' $ROOT/$PKG_BUILD/cmake/boost.cmake

even better :)

EDIT: then you dont have to care when you bump boost for some other reason.

@lrusak
Copy link
Member Author

lrusak commented May 20, 2016

@stefansaraev thanks 👍

@lrusak lrusak removed the Keep Open label May 20, 2016
@ghost
Copy link

ghost commented May 22, 2016

MariaDB?

@MilhouseVH
Copy link
Contributor

MariaDB?

Maybe if/when Kodi officially recognises and supports MariaDB, but for now it's MySQL only.

If you want to use MariaDB instead of MySQL with Kodi, you're on your own, and there have been times when MariaDB hasn't worked with Kodi (MariaDB bugs etc.), so it's additional risk/pain.

@ghost
Copy link

ghost commented May 22, 2016

I see @MilhouseVH :-) Thank you for taking the time explaining it.

@lrusak
Copy link
Member Author

lrusak commented Jun 1, 2016

@MilhouseVH any negative effects?

@MilhouseVH
Copy link
Contributor

Nope, all good.

@MilhouseVH MilhouseVH merged commit b4f3545 into LibreELEC:master Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants