-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql: update to 5.7.12 #366
Conversation
Updated, thanks for testing @MilhouseVH 👍 |
It is possible to instruct mysql 5.7.12 to download correct boost version when building. |
@vpeter4 yes it is, however this is a lot of extra bandwidth when you have to build all the projects :) |
Agree. If boost on a system will need to upgrade back then for mysql should be used different solution. |
what if something else needs "exact" boost 1.58.0 tomorrow? doesnt this work ? : -DDOWNLOAD_BOOST=1 -DWITH_BOOST=$ROOT/$PKG_BUILD/boost_build |
Yes, downloading boost works from mysql itself. |
so, mysql now requires boost for a feature you wont ever use (GIS). why not use 5.5 or 5.6 instead ? |
because tls 1.2 as requested by users |
what's the benefit of using tls in your local network ? |
maybe they want some shared cloud mysql database. who knows 😄 |
so TLSv1 that is available in 5.6 is not enough? |
The |
since boost is only used for GIS it would be safe to make mysql ignore the 1.59 check and compile with 1.60. I have tried that and it works. (just an option) |
thanks @sopparus . I have dropped the boost commit and updated mysql to work with boost 1_60_0 |
|
||
PKG_CONFIGURE_OPTS_HOST="--with-zlib-dir=$ROOT/$TOOLCHAIN" | ||
sed -i "s|BOOST_MINOR_VERSION EQUAL 59|BOOST_MINOR_VERSION EQUAL 60|" $ROOT/$PKG_BUILD/cmake/boost.cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sed -i '/^IF(NOT BOOST_MINOR_VERSION.*$/,/^ENDIF()$/d' $ROOT/$PKG_BUILD/cmake/boost.cmake
even better :)
EDIT: then you dont have to care when you bump boost for some other reason.
@stefansaraev thanks 👍 |
MariaDB? |
Maybe if/when Kodi officially recognises and supports MariaDB, but for now it's MySQL only. If you want to use MariaDB instead of MySQL with Kodi, you're on your own, and there have been times when MariaDB hasn't worked with Kodi (MariaDB bugs etc.), so it's additional risk/pain. |
I see @MilhouseVH :-) Thank you for taking the time explaining it. |
@MilhouseVH any negative effects? |
Nope, all good. |
mysql 5.7.12 needs the exact boost version 1_59_0. So downgrading boost is the simplest solution.
mysql 5.7 bring tls 1.2 encryption.
@MilhouseVH a clean build with this would be appreciated.