Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: replace the initramfs source during post_patch #3724

Merged
merged 1 commit into from Aug 1, 2019

Conversation

lrusak
Copy link
Member

@lrusak lrusak commented Jul 27, 2019

This makes it so we don't have any surprise options appearing or disappearing after the kernel has been unpacked.

Maintainers please update your configs:

aarch64 kernels may have initramfs compression (if the kernel is uncompressed)
arm kernels do not use initramfs compression (the entire kernel is compressed)

We should probably unify that at some point but it is outside of the scope of this PR.

I can either pick your commits and squash them in or you can push them directly to this branch (or you can PR to my branch).

Thanks.

@MilhouseVH
Copy link
Contributor

@lrusak thanks for this. Please squash the RPi/Generic updates using f1ffbd7

There's another couple of "annoyances" when running make oldconfig that are capable of introducing build host specific changes:

# Compiler: gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0

and

CONFIG_GCC_VERSION=70200

Both of these changes should ideally be ignored when submitting a config change to avoid flip-flopping these options/comments whenever one developer submits a minor option change while using a different version of gcc to the previous config submitter. It's a cosmetic thing, but just adds potential noise to a config change and maybe something to bear in mind (as it's not specifically called out in the workflow notes).

@MilhouseVH
Copy link
Contributor

Allwinner: f2665c2

Amlogic: 13175aa

Rockchip: 3ba8b26 (plus extras, @Kwiboo please double check)

@lrusak
Copy link
Member Author

lrusak commented Jul 28, 2019

@MilhouseVH thanks. I've left the commits separate right now until I get a sign off from each maintainer 👍

Copy link
Member

@Kwiboo Kwiboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MilhouseVH Rockchip changes looks good, I have the same changes after a make olddefconfig, thanks!

@MilhouseVH
Copy link
Contributor

Ping @chewitt 😄

@chewitt
Copy link
Member

chewitt commented Aug 1, 2019

fine with me, I'll make the changes (or adjust to whatever was merged) when I next update the current draft PR .. will be a while due to work and other real-life things.

@MilhouseVH MilhouseVH merged commit 3e9df75 into LibreELEC:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants