busybox: add 'xpad' to SUSPEND_MODULES

[lbschenkel]

In some systems, xpad times out during suspend:

[ 4470.773651] xpad 2-1.5:1.6: timed out waiting for output URB to complete, killing
[ 4475.892774] xpad 2-1.5:1.4: timed out waiting for output URB to complete, killing
[ 4481.011717] xpad 2-1.5:1.2: timed out waiting for output URB to complete, killing
[ 4486.130707] xpad 2-1.5:1.0: timed out waiting for output URB to complete, killing
[ 4486.288630] PM: suspend devices took 20.880 seconds

This causes suspend to take a long time to complete. Unloading/reloading
the module during suspend/wakeup successfully works around this issue.

[MilhouseVH]

Excuse my ignorance, but what is xpad?

[lbschenkel]

xpad is the kernel module for dealing with the Xbox One controller. I noticed that my system (LibreELEC 9.1.002, x86-64) was taking an unusual long time to go to sleep when the controller was connected. I have managed to mitigate the issue by creating a script as documented in https://libreelec.wiki/creating_suspend_and_resume_scripts which does rmmod/modprobe but this PR would fix it for all the other users.

[MilhouseVH]

OK thanks, I'll include this in nightly testing for a few days.

[lbschenkel]

Slightly off-topic, but related:

It would be nice if https://github.com/LibreELEC/LibreELEC.tv/blob/3230a0838bb43648a935b8a0f14b0eebd1d8cc26/packages/sysutils/busybox/sleep.d.serial/99-suspend-modules.sh was amended to allow user customization inside /storage/.config, so both the system-specified list and the user-specified list are concatenated together and users could extend the list with new entries, in case they stumble upon other problematic modules.

I didn't submit a PR for that due to not being sure if the maintainers like that approach.

[MilhouseVH]

I didn't submit a PR for that due to not being sure if the maintainers like that approach.

A PR would be welcome. Probably doesn't need to be anything more than http://ix.io/1QuR, and then your /storage/.config/suspend-modules.conf would be:

SUSPEND_MODULES="xpad"

[lbschenkel]

A PR would be welcome. Probably doesn't need to be anything more than http://ix.io/1QuR, and then your /storage/.config/suspend-modules.conf would be:

SUSPEND_MODULES="xpad"

Yes, that is pretty much exactly what I had in mind.