graphic: use GLVND to dispatch graphic API calls #3790
Conversation
|
Latest changes NVIDIA/libglvnd#179 build and work fine with mesa |
|
@evelikov if you possibly have some free time would you be able to give this a quick review? I know you're the one that said we should switch to use GLVND some time ago. 👍 |
- added glvnd options - dropped libGL symlink hacks
| if [ "$DISPLAYSERVER" != "x11" ]; then | ||
| PKG_CONFIGURE_OPTS_TARGET="--disable-glx" | ||
| if [ "${DISPLAYSERVER}" != "x11" ]; then | ||
| PKG_MESON_OPTS_TARGET="-D glx=no" |
| cp -P nvidia_drv.so $INSTALL/$XORG_PATH_MODULES/drivers/nvidia-main_drv.so | ||
| ln -sf /var/lib/nvidia_drv.so $INSTALL/$XORG_PATH_MODULES/drivers/nvidia_drv.so | ||
| mkdir -p ${INSTALL}/${XORG_PATH_MODULES}/drivers | ||
| cp -P nvidia_drv.so ${INSTALL}/${XORG_PATH_MODULES}/drivers/nvidia-main_drv.so |
There was a problem hiding this comment.
don't align things like this. Same for all the lines below
| ln -sf /usr/lib/vdpau/libvdpau_nvidia-main.so.1 /var/lib/libvdpau_nvidia.so | ||
| ln -sf /usr/bin/nvidia-main-smi /var/lib/nvidia-smi | ||
| ln -sf /usr/bin/nvidia-main-xconfig /var/lib/nvidia-xconfig | ||
| ln -sf /usr/lib/libnvidia-ml.so.@NVIDIA_VERSION@ /var/lib/libnvidia-ml.so.1 |
|
looks like someone has a lot of cleanup to do now that this is merged 😸 |
|
Well what's the problem with the alignment? Otherwise readability is down to zero if you install a bunch of files 🤔 |
|
because if you add or remove one then you may have to move the alignment for all the lines. |
|
That's the whole point. Nvidia tends to add, remove or rename libs out of the blue and with this alignment I see on first sight which is missing or has changed. If the "price" for this is to push the spacebar if the file with longest name has randomly changed then I'm willing to do it. Beside that I guess nobody else is maintaining the Nvidia stuff actively anyway 😉 |
|
we have never used alignment before and we aren't about to start now. So please fix it or revert the whole lot. Thanks. |
This PR adds https://github.com/NVIDIA/libglvnd which is already supported by MESA 3D and newer Nvidia drivers. It slightly updates the
xorg-configurescript to create matching symlinks for the new libs and adjusts the mesa & xf86-video-nvidia package to use libglvnd. These changes are mandatory for all upcoming nvidia drivers past version 430 which will drop non-GLVND binaries.It was tested on my Intel i3-6100, Asrock J3455-ITX systems which use the IGP, my workstation which uses a GTX 1060 6GB, on a systems using the legacy-driver with a 8400GS and on a ION2 based system owned by @MilhouseVH
Changes:
some docs:
https://devtalk.nvidia.com/default/topic/915640/multiple-glx-client-libraries-in-the-nvidia-linux-driver-installer-package/
https://devtalk.nvidia.com/default/topic/1032650/linux/unix-graphics-feature-deprecation-schedule/