scripts: image: BUILDER_NAME in image filename #3798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Does |
|
@5schatten no, but i did take a wish for it here LibreELEC/release-scripts#3 (comment) |
|
I don't generally have a problem with this.... but it does make parsing the filename a little trickier as there's now an optional component, but there's not much we can do about that because of backward compatibility. |
MilhouseVH
reviewed
Sep 8, 2019
Co-Authored-By: MilhouseVH <MilhouseVH@users.noreply.github.com>
|
@MilhouseVH i committed your suggestion |
MilhouseVH
approved these changes
Sep 13, 2019
|
Let's see if anyone complains... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to host builds from more then one builder and create a releases.json for each builder, there should be the builder name in the filename and the releases.py needed to be extended to create LibreELEC-9.2-Milhouse just from the file name.