Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm: update to llvm-9.0.0 / updated PKG_URL #3859

Merged
merged 1 commit into from Oct 9, 2019

Conversation

5schatten
Copy link
Contributor

@MilhouseVH
Copy link
Contributor

MISSING        Delta: -26,695,088  #0922: n/a           #0921b: 26,695,088   /usr/lib/libLLVM-8.so
NEW FILE       Delta: 31,495,632   #0922: 31,495,632    #0921b: n/a          /usr/lib/libLLVM-9.so

5MB increase... :(

@lrusak
Copy link
Member

lrusak commented Sep 23, 2019

I’d check the cmake build options for new or changed options as that change size seems way too big

@MilhouseVH
Copy link
Contributor

image comparison: http://ix.io/1WvD

#0922: last night's test build (llvm-8.0.1, pulseaudio-12.2)
#0923b: new test build (llvm-9.0, pulseaudio-13.0)

@5schatten
Copy link
Contributor Author

5schatten commented Sep 27, 2019

I compared both CMakeLists for 9.0 & 8.0 and found this option LLVM_ENABLE_UNWIND_TABLES which is new. https://llvm.org/docs/CMake.html#llvm-specific-variables

LLVM_ENABLE_UNWIND_TABLES:BOOL
Enable unwind tables in the binary. Disabling unwind tables can reduce the size of the libraries. Defaults to ON.

Also there is a new RISChttps://raw.githubusercontent.com/llvm/llvm-project/release/8.x/llvm/CMakeLists.txtV target but we only build AMDGPU so this should not matter.

https://raw.githubusercontent.com/llvm/llvm-project/release/9.x/llvm/CMakeLists.txt
https://raw.githubusercontent.com/llvm/llvm-project/release/8.x/llvm/CMakeLists.txt

@MilhouseVH
Copy link
Contributor

Adding -DLLVM_ENABLE_UNWIND_TABLES=OFF (http://ix.io/1Xbx) seems to get us more-or-less back to where we were with llvm-8.x.

With default LLVM_ENABLE_UNWIND_TABLES (ie. ON):

MISSING        Delta: -26,695,088  #0922: n/a           #0921b: 26,695,088   /usr/lib/libLLVM-8.so
NEW FILE       Delta: 31,495,632   #0922: 31,495,632    #0921b: n/a          /usr/lib/libLLVM-9.so

With -DLLVM_ENABLE_UNWIND_TABLES=OFF:

MISSING        Delta: -26,695,088  #0927: n/a           #0921b: 26,695,088   /usr/lib/libLLVM-8.so
NEW FILE       Delta: 28,091,856   #0927: 28,091,856    #0921b: n/a          /usr/lib/libLLVM-9.so

So a 1.3MB increase with llvm-9.0, which seems more reasonable.

@MilhouseVH MilhouseVH merged commit fb9800f into LibreELEC:master Oct 9, 2019
@5schatten 5schatten deleted the llvm_9.0.0 branch October 10, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants