tools/fixlecode.py: initial commit #3904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this tool will be useful in helping automate the cleanup of build system code (
scripts/*
,config/*
, andpackage.mk
's) so that it is more consistent, initially addressing the following common issues:+=
operator, from:to
{}
around variables, from:to
$()
), from:to
if
statements, andfor
/while
loops, fromto
All fixes are enabled by default, but can be optionally disabled (see below).
It's certainly not perfect, but should do most of the work required and help cut down on the manual labour. I haven't run this on the entire code base, so if anyone finds problematic code then please let me know.
Example command line (outputs summary only, input file is not modified):
Options:
-q
to disable summary, with-Q
to only output summary when a change occurs-d
to output adiff -Naur
of the differences.-w
to overwrite the input file (then usegit diff
to review changes).-f filename
to specify the file(s) to be processed - readstdin
if not specified-o filename
write output tofilename
(orstdout
if filename is-
)-xa
disable append processing-xb
disable brace processing-xs
disable semicolon processing-xt
disable backtick processing