Make kodi-config return a zero exit status #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of blind returning "ok", it is better to convert the test into an |
|
Done, and backport raised as #3985 |
MilhouseVH
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If /storage/.config/kodi.conf doesn't exist (which it doesn't by default), then the failing "test -f" at the end of this script causes it to return a non-zero exit status, which it turn causes systemd to record it as failed when it runs it as a pre-start for the main kodi service (and show it as such in "systemctl status kodi"), which is ugly. Instead force the exit status back to 0.