systemd: prevent unmounting storage via umount.target #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the root mount dependency on systemd-journal.socket and fixes drop-in loading for storage.mount. See systemd/systemd#14040 Signed-off-by: Matthias Reichl <hias@horus.com>
/storage will be unmounted by systemd-shutdown, like /flash. As the squashfs root has several symlinks to /storage it should not be unmounted during the normal shutdown process. This prevents the symlinked files/directories vanishing too early and also removes the "unmount /storage failed" messages when netbooting. Signed-off-by: Matthias Reichl <hias@horus.com>
This was referenced Nov 15, 2019
|
The systemd fix has just been merged into systemd git systemd/systemd@bf7eedb so it should be safe to use and we can drop it on the next systemd bump |
MilhouseVH
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/storage will be unmounted by systemd-shutdown, like /flash.
As the squashfs root has several symlinks to /storage it
should not be unmounted during the normal shutdown process.
This prevents the symlinked files/directories vanishing too early
and also removes the "unmount /storage failed" messages when
netbooting.
Drop-ins for the storage mount unit didn't work before (due to a systemd bug in combination with the order in which we mount filesystems in initramfs), so include the proposed fix which should hopefully make it into the next systemd version.