Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibreELEC-settings: make it easier to disable, or use alternative #3993

Merged
merged 5 commits into from Dec 11, 2019
Merged

LibreELEC-settings: make it easier to disable, or use alternative #3993

merged 5 commits into from Dec 11, 2019

Conversation

MilhouseVH
Copy link
Contributor

@MilhouseVH MilhouseVH commented Nov 17, 2019

Adds a helper to extract the addon id of the specified package (why OpenELEC chose to call the settings package LibreELEC-settings rather than use the addon id baffles me to this day).

Only add the addon id of the configured package to the Kodi manifest if the add-on is enabled, otherwise Kodi will crash on startup.

@MilhouseVH
Copy link
Contributor Author

MilhouseVH commented Nov 17, 2019

Dropped the get_addon_id() helper, adding an extra option is way easier.

Solve the Python addon issues (chrome, docker) by introducing a new post_install_addon() step.

Not yet build tested.

@chewitt chewitt merged commit e5dedd7 into LibreELEC:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants