Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseaudio: don't enable network audio support for everyone by default #4001

Merged
merged 1 commit into from
Dec 8, 2019
Merged

pulseaudio: don't enable network audio support for everyone by default #4001

merged 1 commit into from
Dec 8, 2019

Conversation

MilhouseVH
Copy link
Contributor

From @fritsch:

Are you guys sure you want this: https://github.com/LibreELEC/LibreELEC.tv/blame/85150686feda583445ee7ad35e687eb935865cda/packages/audio/pulseaudio/config/system.pa#L68
having PA open via tcp to everyone
so that every network sink can output via pulse's default device, e.g. BT headset?
...
If it's not a use-case that LE should provide
remove it
makes no sense to announce LE as tcp streaming target
without authentication

This module is needed for network audio, but probably shouldn't be enabled by default - anyone that needs network audio support can load this module themselves in autostart.sh, or via a systemd service.

I'll include this PR in nightly builds - let's see what (if anything) breaks.

@chewitt chewitt merged commit d751c56 into LibreELEC:master Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants