p7zip: needs helping hand with cross-compiling #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p7zip has a very basic build system, which has no support for building into a multi-arch directory.
Consequently it drops the host binaries into
$PKG_BUILD/bin, and the target binaries are also dropped into the same$PKG_BUILD/bin. However if the host7zabinary is already present when building the target (as it normally would) then7zais not created for the target andsystem-toolsinstalls the host binary to the add-on.This change is hack, based on what we used to do for dosfstools-v3, but allows
p7zipto build host and target into arch-specific directories..I've also added a number of security fixes that other distros have been carrying for some time (copied from Arch).
Thanks @dhewg for bringing this up (although you may need to update #4042 - and related PRs - to take account of these changes, sorry!)