Fix digital audio crackling when playing music on non Kodi based setups. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems this effects other platforms, @MilhouseVH can you include in your test build? |
|
Has this been tested yet? |
|
It's been in my test builds for the last week. Nobody has commented, which means it's either not being tested, or isn't causing a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid audio crackling on digital audio on the RPi we need to change the Master/PCM audio volumes to 0db instead of 100%. 100% results in 104db, so a 4db amplification on the RPi and causes a bad experience with audio crackling when playing music.