Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom fonts to be installed in place of liberation fonts #409

Merged

Conversation

@ziggimon
Copy link
Contributor

commented Jun 3, 2016

So we use our own fonts on Plex Media Player and Liberation fonts break our fonts as fontconfig is hardcoded to /usr/share/fonts/liberation.

This PR should address that with an option to put an alternate font using distro option file.

@lrusak

This comment has been minimized.

Copy link
Member

commented Jun 3, 2016

Which fonts do you use? perhaps we should just switch to using that font?

@ziggimon

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2016

Our fonts are collected from here: https://nightlies.plex.tv/directdl/plex-oe-sources/plexmediaplayer-fonts-ttf-1.tar.gz

Unsure if its satisfactory for what fonts you use, but should we want to change fonts in the future it may be handy to have the option to use custom fonts.

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2016

unconditionaly changing fc font path to /usr/share/fonts should be safe.

@lrusak lrusak force-pushed the LibreELEC:master branch from 2d52a20 to c6c222d Jun 19, 2016

@libreelec-jenkins

This comment has been minimized.

Copy link

commented Jul 6, 2016

Can one of the admins verify this patch?

@ziggimon ziggimon force-pushed the plexinc:fix-fontconfig-for-alternate-distributions branch from b5bae93 to ea3c41d Jul 6, 2016

@ziggimon

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2016

I changed the PR to comply.

@lrusak

This comment has been minimized.

Copy link
Member

commented Jul 7, 2016

need to drop that second commit, otherwise looks good

@libreelec-jenkins

This comment has been minimized.

Copy link

commented Jul 7, 2016

Can one of the admins verify this patch?

1 similar comment
@libreelec-jenkins

This comment has been minimized.

Copy link

commented Jul 7, 2016

Can one of the admins verify this patch?

@ziggimon ziggimon force-pushed the plexinc:fix-fontconfig-for-alternate-distributions branch from ea3c41d to 504f12b Jul 7, 2016

@ziggimon

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2016

Not sure how that commit got in there, did reset --hard on the master branch.. Anyways. Cleared now.

@lrusak lrusak merged commit 4cb4fca into LibreELEC:master Jul 7, 2016

@lrusak

This comment has been minimized.

Copy link
Member

commented Jul 7, 2016

thanks for your contribution!

@ziggimon

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2016

Hey whatever helps us help you help us :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.