Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/pkgbuilder.py: assign each subprocess a process group #4177

Merged
merged 3 commits into from
Feb 19, 2020
Merged

scripts/pkgbuilder.py: assign each subprocess a process group #4177

merged 3 commits into from
Feb 19, 2020

Commits on Feb 10, 2020

  1. scripts/pkgbuilder.py: assign each subprocess a process group

    When pkgbuilder.py is terminated with SIGINT (ie. ctrl-c), or exits
    immediately due to a failed job, it is sometimes possible for child
    subprocesses (ie. build tasks) to remain alive and continue running
    in the background.
    
    To fix this, assign each subprocess a new process group identifier,
    and capture the pid of each child subprocess so that on shutdown we
    can kill the entire child process group (ie. kill the child subprocess,
    and all subprocesses the child subprocess may have created) for any
    builder processes that are still running.
    MilhouseVH committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    8e2c02f View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. Configuration menu
    Copy the full SHA
    a6f81e4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef86eb8 View commit details
    Browse the repository at this point in the history