enable support for BPF IR decoders #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable CONFIG_BPF_SYSCALL and CONFIG_CGROUP_BPF Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
autoreconf trips over the newer ax_proc_doxygen.m4 file from our autoconf-archive which is not compatible with the ancient version used in v4l-utils, just disable it as we don't want to build docs anyways. Signed-off-by: Matthias Reichl <hias@horus.com>
note: building bpf decoders is disabled as that would require clang in the toolchain. Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
…ries Note: when bumping v4l-utils the BPF decoders in util/keytable/bpf_protocols should be locally rebuilt (requires clang and libelf-dev installed) and this package bumped with updated versions. Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
HiassofT
force-pushed
the
le10-lirc-bpf
branch
from
6dbdb9f
to
5556947
Compare
|
updated the kernel configs and added the missing |
|
No reported issues, ready to go? |
|
this is good to go from my side, no further changes planned ATM. Better push the button before we start getting conflicts with kernel configs |
MilhouseVH
approved these changes
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel and v4l-utils gained support for BPF IR decoders a while ago but we hadn't enabled it yet in our configs.
With BPF IR decoder support enabled a lot of remotes that previously required userspace lircd can now be decoded by the kernel.
This PR also includes the (experimental) lircd2toml.py script from the v4l-utils contrib directory which can convert lircd.conf files into toml files usable by ir-keytable. While it's not perfect yet and may struggle with some lircd.conf files it's already doing a very good job.
Compiling the BPF decoders requires clang and since adding clang as a (rather hefty) dependency to build 8 very small object files didn't look like a great idea to me I decided to just build them locally and include the precompiled binaries via the separate ir-bpf-decoders package. These protocol decoders don't seem to change too often so this shouldn't be a huge problem to update them every now and then.
Note: this PR depends on #4191 otherwise the BPF decoders won't be included in the image