Add some missing dependencies; fallout from #4088 #4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dhewg
commented
Feb 11, 2020
•
dhewg
commented
- the first two issues/patches poped up during compile testing
- the comskip and jre-libbluray patches fix regressions from cleanup dependencies & addons, and add an option to wipe intermediate build dirs #4088
- the .config recreation was introduced with cleanup dependencies & addons, and add an option to wipe intermediate build dirs #4088 and needs improvements for linux: bail when config options are missing #4201
dhewg
changed the title
|
Added two patches and retitled PR accordingly |
build.LibreELEC-RPi2.arm-9.80-devel/toolchain/bin/host-g++: not found
CMake Error at CMakeLists.txt:7 (find_package): By not providing "Findglm.cmake" in CMAKE_MODULE_PATH...
The static ffmpegx requires this due to omx: libavcodec/omx.c:93: error: undefined reference to 'dlsym'
Instead of attempting to recreate the .config of the initial build (and failing at it), just (re)store it along with Module.symvers. This fixes inconsistencies like CONFIG_EXTRA_FIRMWARE not getting set on an autoremove+unpack cycle and prepares for LibreELEC#4201.
MilhouseVH
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.