libxkbcommon: fix Generic build #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CvH
commented
Feb 22, 2020
CvH
commented
- allows building of libxkbcommon for generic (we don't do it for generic yet)
- no idea if this have a side effect
|
should be for x11 build only |
CvH
force-pushed
the
10.0/libx-fix
branch
2 times, most recently
from
2f1b78c
to
5f3053e
Compare
|
changed it that it just applies to x11 builds |
MilhouseVH
suggested changes
Feb 25, 2020
There was a problem hiding this comment.
I really don't like the conditional function... can you apply this patch? http://ix.io/2cu3
|
pushed fix like discussed at slack |
MilhouseVH
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.