Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: use FAT16 for Generic system partition / dosfstools: reduce fsck.fat log spam #4275

Merged
merged 3 commits into from
Apr 4, 2020

Conversation

mglae
Copy link
Contributor

@mglae mglae commented Mar 22, 2020

Since dosfstools bump to 4.1 (#3858) mkfs.fat used in installer automatically format the system partition FAT32 instead of FAT16.

One difference in the file system layout is the introduced FAT32 backup boot sector. On Generic build the Syslinux legacy installation is writing the boot sector and omitting the backup boot sector. Therefore fsck.fat complains about differences in boot and backup sector on every boot generating a long diff, i.e.:

[    3.451803] fsck: CP437: Invalid argument
[    3.451916] fsck: fsck.fat 4.1 (2017-01-24)
[    3.452089] fsck: There are differences between boot sector and its backup.
[    3.452270] fsck: This is mostly harmless. Differences: (offset:original/backup)
[    3.452476] fsck: 3:53/6d, 4:59/6b, 5:53/66, 6:4c/73, 7:49/2e, 8:4e/66, 9:55/61, 10:58/74
[    3.452680] fsck: , 90:fa/0e, 91:fc/1f, 92:31/be, 93:c9/77, 94:8e/7c, 95:d1/ac, 96:bc/22
[    3.452887] fsck: , 97:76/c0, 98:7b/74, 99:52/0b, 100:06/56, 101:57/b4, 102:1e/0e, 103:56/bb
[    3.453082] fsck: , 104:8e/07, 105:c1/00, 106:b1/cd, 107:26/10, 108:bf/5e, 109:78/eb
--- 57 lines deleted ---
[    3.464837] fsck: , 478:20/00, 479:65/00, 480:72/00, 481:72/00, 482:6f/00, 483:72/00
[    3.465033] fsck: , 484:0d/00, 485:0a/00, 504:fe/00, 505:02/00, 506:b2/00, 507:3e/00
[    3.465139] fsck: , 508:18/00, 509:37/00
[    3.465261] fsck: Not automatically fixing this.
[    3.465404] fsck: /dev/sda1: 12 files, 63314/130812 clusters

To avoid this annoying output format the system partition FAT16 again on new installations. For existing installations reduce log spam by adding a fsck.fat patch to suppress the diff output in automatic mode .

Third commit is more cosmetic setting the GPT partition labels to the defined names instead of using "primary".

Note: The image generation with scripts/mkimage using mformat of mtools is not affected by the implicit file system change.

@chewitt chewitt merged commit 383f640 into LibreELEC:master Apr 4, 2020
@mglae mglae deleted the le10_installer_fat16 branch April 5, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants