Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: remove beelink mouse patch #4322

Merged
merged 1 commit into from Apr 23, 2020

Conversation

chewitt
Copy link
Member

@chewitt chewitt commented Apr 13, 2020

I'm still looking for a better solution for this device, but until then, this corrects fat thumbs.

@MilhouseVH
Copy link
Contributor

Unfortunately this doesn't fix the Kodi whine - we're still getting the following in Kodi even with this PR:

2020-04-13 21:27:27.993 T:1213   DEBUG: LoadMappings - loaded node "Motorola Nyxboard Hybrid"
2020-04-13 21:27:27.993 T:1213   DEBUG: LoadMappings - loaded node "CEC Adapter"
2020-04-13 21:27:27.993 T:1213   DEBUG: LoadMappings - loaded node "Pulse-Eight CEC Adapter"
2020-04-13 21:27:27.993 T:1213   ERROR: LoadMappings - ignoring node "iMON HID device" with invalid vendor_product attribute
2020-04-13 21:27:27.993 T:1213   DEBUG: LoadMappings - loaded node "iMON HID device"
2020-04-13 21:27:27.993 T:1213   DEBUG: LoadMappings - loaded node "WETEK Play remote"
2020-04-13 21:27:27.993 T:1213   DEBUG: LoadMappings - loaded node ""
2020-04-13 21:27:27.993 T:1213   DEBUG: Add-on bus: Registering add-on peripheral.joystick

Full log: http://ix.io/2hVe

We probably need to look at the kodi code to understand why it is complaining.

This is /usr/share/kodi/system/peripherals.xml from the test system: http://ix.io/2hVc

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Apr 13, 2020

The issue is pretty clear:

https://github.com/xbmc/xbmc/blob/75b31098a8800da653b373cd99a025b483029cfc/xbmc/peripherals/Peripherals.cpp#L510-L515

Kodi only expects vendor:product ie. 15C2:32 and not 0003:2319:00B2:0003

@HiassofT
Copy link
Member

yes, exactly, this change doesn't make sense. see also my comment 2 weeks ago #4220 (comment)

on closer inspection I can't see how the beelink remote change could have any (positive) effect. Kodi simply ignores vendor:product entries that don't have exactly one colon

see https://github.com/xbmc/xbmc/blob/master/xbmc/peripherals/Peripherals.cpp#L507-L520

my guess is the beelink remote commit can simply be dropped

@chewitt chewitt changed the title kodi: fix typo in beelink mouse patch kodi: remove beelink mouse patch Apr 23, 2020
@chewitt
Copy link
Member Author

chewitt commented Apr 23, 2020

I'm not seeing crazy behaviour in current dev builds, so either something changed in recent Kodi or in Linux 5.7, but either way this doesn't appear to be needed, so the patch is dropped.

@MilhouseVH MilhouseVH merged commit 3cea359 into LibreELEC:master Apr 23, 2020
@chewitt chewitt deleted the beelink-remote-kodi-fix branch April 25, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants