Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALSA: update to 1.2.3 #4410

Merged
merged 5 commits into from Jun 16, 2020
Merged

ALSA: update to 1.2.3 #4410

merged 5 commits into from Jun 16, 2020

Conversation

nouman8
Copy link
Contributor

@nouman8 nouman8 commented Jun 9, 2020

No description provided.

@HiassofT
Copy link
Member

Please don't create PRs for stuff you didn't build and runtime-test.

With the alsa-lib bump even ./scripts/unpack alsa-lib fails as alsa-lib-asound.conf_configdir.patch doesn't apply.

hias@tv:/ssd/libreelec/libreelec-master-tmp$ ./scripts/unpack alsa-lib
UNPACK      alsa-lib
    APPLY PATCH (common)      packages/audio/alsa-lib/patches/alsa-lib-asound.conf_configdir.patch
patching file src/conf/alsa.conf
Hunk #1 FAILED at 10.
1 out of 1 hunk FAILED -- saving rejects to file src/conf/alsa.conf.rej
*********** FAILED COMMAND ***********
patch -d $(echo "${PKG_BUILD}" | cut -f1 -d\ ) -p1 1>&${VERBOSE_OUT}
**************************************

You need to rebase that patch

Copy link
Member

@HiassofT HiassofT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good now!

@HiassofT HiassofT merged commit 0a3ad5e into LibreELEC:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants