Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for NXP/iMX6 #4656

Merged
merged 3 commits into from Nov 15, 2020
Merged

Fixes for NXP/iMX6 #4656

merged 3 commits into from Nov 15, 2020

Conversation

by-gnome
Copy link
Contributor

@by-gnome by-gnome commented Nov 13, 2020 •
edited

  • update linux config for 5.9
  • fix kodi build
  • fix IP firewall

jernejsk
jernejsk reviewed Nov 13, 2020
View reviewed changes
packages/linux/package.mk Outdated Show resolved Hide resolved
@lrusak
Copy link
Member

lrusak commented Nov 13, 2020

You shouldn't need to build the firmware into the kernel. I've never needed to do that for i.MX6 before. What is the reason for doing so?

@by-gnome
Copy link
Contributor Author

@lrusak i.MX SDMA support is configured as built-in and if we don't make
SDMA firmware built-in we will see in the log:

imx-sdma 20ec000.sdma: Direct firmware load for imx/sdma/sdma-imx6q.bin failed with error -2
imx-sdma 20ec000.sdma: external firmware not found, using ROM firmware

yes, firmware won't load, but SDMA will work. I'm sorry but I don't like this.
Well if I configure i.MX SDMA support as a module at least one or both audio
devices (imx6-wandboard-sgtl5000, imx-spdif) in my Wandboard won't work.

lrusak
lrusak reviewed Nov 14, 2020
View reviewed changes
packages/linux/package.mk Outdated Show resolved Hide resolved
lrusak
lrusak reviewed Nov 14, 2020
View reviewed changes
packages/linux/package.mk Outdated Show resolved Hide resolved
@by-gnome
Copy link
Contributor Author

I removed commits related to firmware (sdma, vpu, brcm), these changes can be made with another PR. Thanks for your time.

lrusak
lrusak approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@lrusak lrusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort.

We will need to replace the plane usage patch though. I can do that later.

chewitt
chewitt approved these changes Nov 15, 2020
View reviewed changes
Copy link
Member

@chewitt chewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having never owned or used iMX6 hardware I don't really have an opinion .. but LGTM :)

@jernejsk jernejsk merged commit df2a079 into LibreELEC:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewitt chewitt chewitt approved these changes

@lrusak lrusak lrusak approved these changes

@jernejsk jernejsk jernejsk approved these changes

Assignees
No one assigned
Labels
BUGFIX LE 10.0 NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@by-gnome @lrusak @chewitt @jernejsk