Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lirc: replace parallel build fix #474

Merged
merged 1 commit into from Jun 24, 2016
Merged

Conversation

InuSasha
Copy link
Member

lirc failed with parallel build (missing library "cannot find -llirc").
disable it temporary

@CvH
Copy link
Member

CvH commented Jun 21, 2016

hmm this should fix it

@lrusak
Copy link
Member

lrusak commented Jun 21, 2016

Reset your git, there is a patch included that already addresses this

@InuSasha
Copy link
Member Author

InuSasha commented Jun 21, 2016

it was not help on my system...

checked my build log
i builded the commit with this specific patch (c6c222d),
but it was failing, with the missing lirc. The unpack show me the patch was applied.

tomorrow i can test the actual master again (with & without my patch)

edit: tested again with actual master -> same failure.
with me patch it is working.
I found a interesting behavior. After a working build (non-parallel) build, all build will success (parallel and non-parallel builds), until you make a clean.

@mcaptur
Copy link
Contributor

mcaptur commented Jun 22, 2016

inusasha same here

@stefansaraev
Copy link
Contributor

stefansaraev commented Jun 22, 2016

most likely, liblirc is picked from sysroot instead of source tree next build, thats why it fails once after make clean

settings MAKEFLAGS += -j1 is perfectly acceptable for known broken packages, even if it's broken on just one configuration (today it's one - tomorrow - many)

EDIT: package, that uses it's own libs from sysroot, not from it's own source tree, is a potential future trouble (when you bump it, if you dont make clean, it may link itself against wrong static lib, for example), but that's unrelated to this PR. EDIT: or well, could be, depends. this PR may fix that issue, too, so just push it

@InuSasha
Copy link
Member Author

found a better solution, that fixes parallel build.
Will update PR, soon.

@InuSasha
Copy link
Member Author

it builds fine on my system in parallel mode, now.
@mcaptur can you test it, too?

@senufo
Copy link

senufo commented Jun 23, 2016

I have the same problem. I have add lirc-0003-add-dependencies-to-fix-parallel-build-issue.patch file in packages/sysutils/lirc/patches/ and now

PROJECT=RPi2 ARCH=arm make release

work fine

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Jun 23, 2016

it builds fine on my system in parallel mode, now.

Change PR title? :)

@InuSasha InuSasha changed the title lirc: do not build parallel lirc: replace parallel build fix Jun 23, 2016
@InuSasha
Copy link
Member Author

@MilhouseVH done

@lrusak lrusak merged commit fd0391f into LibreELEC:master Jun 24, 2016
@InuSasha InuSasha deleted the fixes/lirc_build branch June 24, 2016 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants