Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: rework #477

Merged
merged 1 commit into from Jul 5, 2016

Conversation

Projects
None yet
3 participants
@awiouy
Copy link
Contributor

commented Jun 22, 2016

I wanted to know how building FFmpeg for LibreELEC compared to a vanilla FFmpeg cross compilation. I think this is it.

The only update is that --enable-pic was added for aarch64.

The other changes should be cosmetic:

  • removed the default and autodetected build options
  • removed superfluous variables (FFMPEG_CPU, FFMPEG_FPU and FFMPEG_PIC)
  • split the code into logic for dependencies and logic for pre_configure_target.

The output of the configure step is the same as with the previous version of ffmpeg for Generic and RPi2. We could maybe use Jenkins to check the other builds

@awiouy awiouy force-pushed the awiouy:ffmpeg-rework branch from c40fa9e to dce7cca Jun 22, 2016

@awiouy awiouy force-pushed the awiouy:ffmpeg-rework branch 2 times, most recently from ea56d33 to f180374 Jun 23, 2016

@awiouy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2016

This is now the first step of a rework of the ffmpeg package.

Changes are cosmetic and include

  • systematic use of quotes
  • remove unset variable FFMPEG_CPU
  • set systematically --enable-pic, instead of inconsistent use of --enable-pic and -fPIC
  • remove useless setting of FFMPEG_FPU=""
  • remove strip_lto and strip_gold, default stripping appears to work fine on RPi2
  • remove inconsistent setting of --extra-version
  • remove useless setting of --build-suffix
  • export is not required
  • explicity --disable-neon and --disable-hardcoded-tables when they do not apply

Please merge

@awiouy awiouy force-pushed the awiouy:ffmpeg-rework branch 3 times, most recently from 89c2f12 to 41a38c5 Jun 23, 2016

@awiouy awiouy force-pushed the awiouy:ffmpeg-rework branch from 41a38c5 to e4888b9 Jun 23, 2016

@CvH CvH removed the WORK IN PROGRESS label Jun 23, 2016

@lrusak lrusak merged commit e2817f8 into LibreELEC:master Jul 5, 2016

@lrusak

This comment has been minimized.

Copy link
Member

commented Jul 5, 2016

thanks!

@awiouy awiouy deleted the awiouy:ffmpeg-rework branch Jul 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.