Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch for fixing subtitles in 3D MVC videos for RPI2/3 #4879

Closed

Conversation

TheMontezuma
Copy link

Workaround to fix xbmc/xbmc#16362

@chewitt
Copy link
Member

chewitt commented Jan 7, 2021

@popcornmix is there a reason this patch has not been merged upstream?

@TheMontezuma even if we accept/merge the patch there are currently no plans for an LE 9.2.7 release.

@TheMontezuma
Copy link
Author

TheMontezuma commented Jan 7, 2021

@popcornmix is there a reason this patch has not been merged upstream?

Good question. I'm also very interested to understand the background.
The fix was merged into newclock5 branch:
popcornmix/xbmc@6af7c63

For me 3D MVC playback is an ultimate feature of the RPI3 + LibreELEC/KODI combo.
I was really disappointed to discover that the PGS subtitles are rendered not correctly (probably due to support for crappy SBS/TAB formats). Thanks to @HiassofT I was able to build LE locally and I tested the patch on the LE 9.2 branch.
I'm actually done, but I know that other users miss this feature, so I wanted to contribute.
Ideally, the fix should go into a KODI branch, which will be the base for the future LE verions.

@TheMontezuma even if we accept/merge the patch there are currently no plans for an LE 9.2.7 release.

I see, but you never know :) There are any way other commits on top of LE 9.2.6

@TheMontezuma
Copy link
Author

Below is the history of: xbmc/cores/VideoPlayer/DVDCodecs/Overlay/DVDOverlayCodecFFmpeg.cpp
The lower red arrow points to the commit tagged with newclock5_18.9-Leia (the uppper arrow points to a commit with the fix).

history

@TheMontezuma
Copy link
Author

I have tested now 2D videos and realized that the subtitles vertical position is wrong (they are displayed below the visible area)...

@TheMontezuma
Copy link
Author

I ammended the commit to check one more condition.
After that I successfully tested 3D and 2D videos with subtitles.

@popcornmix
Copy link
Contributor

There's been a couple of PRs to fix this, but they've not received much interest.
xbmc/xbmc#17317
xbmc/xbmc#8254

@TheMontezuma
Copy link
Author

There's been a couple of PRs to fix this, but they've not received much interest.

From developers or from users?

@TheMontezuma
Copy link
Author

No interest, then let's close it.
LibreELEC is anyway not the right place to fix KODI issues :)

@TheMontezuma TheMontezuma deleted the distorted-subtitles branch January 12, 2021 18:34
@TheMontezuma TheMontezuma restored the distorted-subtitles branch January 12, 2021 23:39
@TheMontezuma TheMontezuma deleted the distorted-subtitles branch January 12, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants