Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adafruit-libraries: new library addon with python libraries from adafruit #509

Merged
merged 1 commit into from
Jul 5, 2016

Conversation

InuSasha
Copy link
Member

@InuSasha InuSasha commented Jul 3, 2016

addon starts with all libraries emanate from the old Raspberry-Pi-Python-Code.
The three libraries from the rpi-tools was migrated to this packages, too.

@chewitt
Copy link
Member

chewitt commented Jul 3, 2016

@InuSasha
Copy link
Member Author

InuSasha commented Jul 3, 2016

@chewitt you want color, you get color :)
icon replaced with your version

@CvH
Copy link
Member

CvH commented Jul 3, 2016

@InuSasha could you shuffle the lines (and drop some of them) in addons/libraries/adafruit-libraries/package.mk shown here (to follow the standard package schema which is not yet adopted by all addons - my bad)
also the change in the changelog.txt is missing for rpi-tools (due the rev bump it is "needed")

@InuSasha
Copy link
Member Author

InuSasha commented Jul 3, 2016

@CvH is there a full description of package.mk format, and is it linked in the CONTRIBUTING.md? (I have not seen it)

edit: upadted

@CvH
Copy link
Member

CvH commented Jul 3, 2016

@InuSasha sadly not yet (my bad - I have to do it asap) - btw your changes are fine

@chewitt
Copy link
Member

chewitt commented Jul 4, 2016

I'll "Ask the audience" for input. Should this be "Adafruit Libraries" or "Adafruit Tools" to match other bundles that we called "tools". RSVP :)

@InuSasha
Copy link
Member Author

InuSasha commented Jul 4, 2016

I decided to "libraries", because there is no executable in the package. Only python modules.

@MilhouseVH
Copy link
Contributor

I'd keep it as "libraries", since "tools" could imply complete programmes (scripts, executables etc.)

@chewitt chewitt merged commit e32599f into LibreELEC:master Jul 5, 2016
@chewitt
Copy link
Member

chewitt commented Jul 5, 2016

built and published .. thanks @InuSasha

@InuSasha InuSasha deleted the feature/adafruit branch July 5, 2016 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants