New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cpu temperature readings for devices with aml_thermal interface #526
Conversation
Many thanks, looks good to me. Don't forget to submit this to Kodi! :) |
I already did. Here is the link to the PR: xbmc/xbmc#10091 |
Btw. Is the cputemp script still in use? It probably would make sense to split it in two scripts - cputemp and gputemp - and not only to create a gputemp symlink. |
I've added "don't merge" as this is clearly pending upstream agreement on changes |
The PR (xbmc/xbmc#10091) to Kodi is closed and they won't include it yet. In the meantime I created a PR (codesnake/linux#6) ) at @codesnake's Amlogic kernel (the amlogic kernel in LE) for integrating a patch, which let's the aml_thermal interface work. Codesnake commented also in the closed PR that he will check the aml_thermal functionality in this kernel. So let's see what he will find out. |
@drieschel any updates here? Whats the state of this upstream? |
@lrusak This should work with Wetek Core and on all other Meson8* devices at least. I will check what have to be done in the kernel conf and update this pr soon. Was a bit busy the last time. |
@drieschel Can we see CPU temperature on wetek play devices in kodi interface ? Second question - is it possible to see cpu temperature through ssh in linux terminal ? I just to be sure that my wetek play is not overheated |
Appending advancedsettings.xml with cputempcommand does it just fine. Kodi wiki on that section in advancedsettings.xml: http://kodi.wiki/view/advancedsettings.xml#cputempcommand |
it will work with wetek play ? In wiki wetek doesn't mention |
@Stane1983 can make you make a new PR for that for the existing amlogic projects? |
@lrusak I can only check and commit patch for WeTek Play (version 1) as it's only device I have from WeTek. And that only if temp can be read from one of sysfs nodes. MX devices as far as I remember are using one of ADC channels for reading temperature. Have to test. Other 2 devices maybe to be PR by @codesnake or all 3? |
I can test on all three but wont be home for a couple days so unless someone gets to it sooner than I. The easiest thing to do is just make a PR for all three then I can kick of some builds with jenkins and have the builds ready to test when I get home. |
Also for 3.14 kernel, Amlogic thermal driver must be enabled for this to work. My project is based on WeTek Hub where it is not enabled (Kconfig of aml thermal driver must select/depend on THERMAL, CPU_THERMAL, CPUCORE_THERMAL, GPU_THERMAL and GPUCORE_THERMAL to compile). |
I hope this can add soon, BTW if i connect from PC internet browser and try look tv-shows (Wetek play 1 IP-address) processor running 100% and option not show tv-show information. |
@drieschel I'm not sure if this is needed anymore? seems the CPU temp is working ok on my Odroid C2 using the latest git |
@lrusak It's still needed for arm devices, ie meson8. Sorry for my delay. Working a lot and need to finish my project. But didn't forget this and will care about as soon as I have a bit more free time. |
Any updates here? |
@lrusak Not yet. I have problems updating my LE fork to the actual state. First I will do this and then I can create a new PR. So I will close it now. |
Adds correct cpu temperature readings for Amlogic devices which have the aml_thermal (AML_PLATFORM_THERMAL) interface enabled.
@MilhouseVH This time everything in a single commit (hopefully)^^