Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdrm: update to 2.4.105 #5301

Merged
merged 1 commit into from Apr 26, 2021
Merged

libdrm: update to 2.4.105 #5301

merged 1 commit into from Apr 26, 2021

Conversation

heitbaum
Copy link
Contributor

@heitbaum heitbaum commented Apr 8, 2021

update 2.4.104 (2021-01-11) to 2.4.105 (2021-04-07)
commits: https://gitlab.freedesktop.org/mesa/drm/-/commits/master/

Release seems to only have changes for Intel and AMD.

Release notes: https://lists.freedesktop.org/archives/dri-devel/2021-April/302515.html

update 2.4.104 (2021-01-11) to 2.4.105 (2021-04-07)
commits: https://gitlab.freedesktop.org/mesa/drm/-/commits/master/
@mglae mglae merged commit 97b5196 into LibreELEC:master Apr 26, 2021
@heitbaum heitbaum deleted the bumplibdrm branch April 26, 2021 20:37
@jernejsk
Copy link
Member

This PR breaks HW decoding on Allwinner H6 and possibly all other AW SoCs. Offending commit is https://gitlab.freedesktop.org/mesa/drm/-/commit/b362850689d1b0048b7f4641cc236128b5a43773

@knaerzche @HiassofT Can you test RK and RPi and check if playback works?

@lrusak I have a feeling that Kodi doesn't correctly handles modifiers. H6 DRM driver doesn't support any modifiers, so probably correct function call would be drmModeAddFB2 (w/o modifiers).

@HiassofT
Copy link
Member

very quick test on RPi4 (with H264 and HEVC) looks good so far

@mglae
Copy link
Contributor

mglae commented Apr 27, 2021

The commit is already reverted in libdrm master: https://gitlab.freedesktop.org/mesa/drm/-/commit/40f73d0b0b3936ccadc693edc25aad70c1225766

We can work around the issue by adding the patch and wait for 2.4.106.

But released 2.4.105 is unfortunately incompatible to the Kodi implementation.

@jernejsk
Copy link
Member

yeah, backporting that patch would be ideal, so at least nightly images are not broken.

@knaerzche
Copy link
Contributor

No issues for RK either. Should probably be changed in kodi even if libdrm reverted this (for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants