Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdrm: also install modeprint and proptest tests #5371

Closed
wants to merge 1 commit into from

Conversation

HiassofT
Copy link
Member

@HiassofT HiassofT commented May 14, 2021

These test programs are already built but haven't been included in image yet.

They are quite handy when testing drm stuff and only add about 40k (uncompressed) to the image

Signed-off-by: Matthias Reichl <hias@horus.com>
@lrusak
Copy link
Member

lrusak commented May 14, 2021

I'm fine with this although I never added them before because I always thought they we rather clunky to use and may only be needed very rarely, in which case I would just copy the binary over to test.

@HiassofT
Copy link
Member Author

I've been using modetest before but recently found out that modeprint is really handy at times on RPi(4) as it doesn't spam me with the bazillion planes info which often I'm not too interested in - and if I forget to pipe output through less the scrollback buffer of my terminal is full of plane info. Same goes for proptest

LibreELEC:~ # modetest -M vc4 -c -p | wc -l
1933
LibreELEC:~ # modeprint vc4 | wc -l
112
LibreELEC:~ # proptest -M vc4 | wc -l
158

@lrusak
Copy link
Member

lrusak commented May 16, 2021

I've been using modetest before but recently found out that modeprint is really handy at times on RPi(4) as it doesn't spam me with the bazillion planes info which often I'm not too interested in - and if I forget to pipe output through less the scrollback buffer of my terminal is full of plane info. Same goes for proptest

LibreELEC:~ # modetest -M vc4 -c -p | wc -l
1933
LibreELEC:~ # modeprint vc4 | wc -l
112
LibreELEC:~ # proptest -M vc4 | wc -l
158

meh. modetest can do what the others already do (and more) so there really isn't any reason to add them IMO. If you can't pipe the output isn't really a valid reason to add them 😄

When I was developing the entire drm/gbm system for kodi I only ever needed modetest

@CvH
Copy link
Member

CvH commented May 16, 2021

shouldn't we add those stuff in a dev addon or similar ?
adding stuff that "nobody" needs besides at dev stage ? or maybe just add if the image is a dev image ?

@CvH CvH added LE 11.0 and removed LE 10.0 labels Aug 4, 2021
@chewitt
Copy link
Member

chewitt commented Feb 4, 2022

@HiassofT is this PR still needed? .. support seems to have evolved some way since the original submission date. If still useful then the PR needs a rebase :)

also just noticed that it targets LE10 branch, not master.

@HiassofT
Copy link
Member Author

HiassofT commented Feb 4, 2022

I hadn't used these tools since then so let's just close the PR

@HiassofT HiassofT closed this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants