Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagedecoder.raw: link against static lcms2 #5525

Merged
merged 3 commits into from Aug 3, 2021

Conversation

heitbaum
Copy link
Contributor

@heitbaum heitbaum commented Aug 2, 2021

Referenced in bug #5524

ldd looks correct now

nuc11:/var/media/DATA/home-rudi/LibreELEC.tv # ldd build.LibreELEC-Generic.x86_64-10.0-devel/addons/imagedecoder.raw:target/imagedecoder.raw/imagedecoder.raw.so.3.0.1
        linux-vdso.so.1 (0x00007ffcabbdf000)
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x00007f9e352f5000)
        libm.so.6 => /usr/lib/libm.so.6 (0x00007f9e351b4000)
        libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x00007f9e3519a000)
        libc.so.6 => /usr/lib/libc.so.6 (0x00007f9e34fe2000)
        /usr/lib64/ld-linux-x86-64.so.2 (0x00007f9e35662000)

Will run test before requesting pull. Test done on TGL with a CR2.

@heitbaum heitbaum linked an issue Aug 2, 2021 that may be closed by this pull request
@vpeter4
Copy link
Contributor

vpeter4 commented Aug 2, 2021

Why not using PKG_TOOLCHAIN="autotools" instead of manual call of autoreconf?

@heitbaum
Copy link
Contributor Author

heitbaum commented Aug 2, 2021

Tested on http://www.rawsamples.ch/raws/canon/RAW_CANON_EOS_1DX.CR2

2021-08-02 21:41:57.554 T:575685 INFO <general>: CAddonMgr::FindAddon: imagedecoder.raw v3.0.1.5 installed

nuc11:~/.kodi/temp # tail -f kodi.log | grep image 2021-08-02 21:57:09.993 T:581677 INFO <general>: ADDON: Dll Destroyed - libraw image decoder

displays correctly after adding advanced settings:

# cat .kodi/userdata/advancedsettings.xml 
<advancedsettings version="1.0">
    <pictureextensions>
        <add>.arw|.cr2|.dng|.nef</add>
    </pictureextensions>
</advancedsettings>

@heitbaum
Copy link
Contributor Author

heitbaum commented Aug 2, 2021

Why not using PKG_TOOLCHAIN="autotools" instead of manual call of autoreconf?

@vpeter4 - thanks that did the trick.

@heitbaum heitbaum marked this pull request as ready for review August 2, 2021 12:05
@CvH CvH merged commit 78c5a1b into LibreELEC:master Aug 3, 2021
@heitbaum heitbaum deleted the imagedecoder.raw branch August 3, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] libraw image decoder not working
3 participants