prometheus-node-exporter: initial addon #5549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvH
reviewed
Aug 15, 2021
packages/addons/service/prometheus-node-exporter/source/bin/prometheus-node-exporter.start
Outdated
Show resolved
Hide resolved
packages/addons/service/prometheus-node-exporter/source/default.py
Outdated
Show resolved
Hide resolved
packages/addons/service/prometheus-node-exporter/source/settings-default.xml
Outdated
Show resolved
Hide resolved
packages/addons/service/prometheus-node-exporter/source/resources/settings.xml
Outdated
Show resolved
Hide resolved
...ns/service/prometheus-node-exporter/source/system.d/service.prometheus-node-exporter.service
Outdated
Show resolved
Hide resolved
Thx for review ! |
|
@Celedhrim 3x Icon suggestions attached.
|
CvH
reviewed
Aug 17, 2021
packages/addons/service/prometheus-node-exporter/source/bin/prometheus-node-exporter.start
Outdated
Show resolved
Hide resolved
packages/addons/service/prometheus-node-exporter/source/settings-default.xml
Outdated
Show resolved
Hide resolved
...ns/service/prometheus-node-exporter/source/system.d/service.prometheus-node-exporter.service
Outdated
Show resolved
Hide resolved
Yep. Just finished work. Will have a look after dinner ✅ |
Many thx ! I'll take the first one ! :D |
mglae
reviewed
Aug 17, 2021
...ns/service/prometheus-node-exporter/source/system.d/service.prometheus-node-exporter.service
Outdated
Show resolved
Hide resolved
mglae
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icon is not very good , but :
https://forum.libreelec.tv/thread/24362-addon-icons/
Addon tested on pi4 without issue.