inputstream.adaptive: add bento4 dependancy #5975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given xbmc/inputstream.adaptive@70625e7 - bento4 is now not included in the @SupervisedThinking thanks for picking this up. |
|
|
Adding the below allows bento4 to use the inputstream.adaptive supplied patches - but now a recursive DEPEND-ancy The patches do apply cleanly but build of bento4 fails. |
heitbaum
force-pushed
the
bento4
branch
2 times, most recently
from
da00bf6
to
9771056
Compare
|
@SupervisedThinking - this now builds successfully with bento4 as a dependancy. The ** Ideally bento4 should make sure that the |
That smells like a circular dependency? |
A way out: copy the patches to bento4 and check in inputstream.adaptive pre_build if they are the latest ones. |
|
o_O. why not move the patches where they belong. to bento4/patches/ ? |
|
@heitbaum as @stefansaraev said & I mentioned: just copy & paste the patches provided by inputstream.adaptive & add a note in the package file to bump the patchset of bento4 if inputstream is updated. |
Doesn't |
|
current state |
|
@CvH and all others excellent feedback. I know how I want to fix this now. Just need to sit down and do it 👍 |
|
I have gone with |
CvH
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential improvements:
inputstream.adaptivehappens first (due to the dependancy on bento4 in in TARGET)- but a DEPEND-ancy check should be put in place to ensure the unpackinputstream.adaptiveoccurs first in thebento4/package.mkfile - making the patches available to bento4.Thoughts anyone?