Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distro: disable iscsi support #6356

Merged
merged 1 commit into from Apr 17, 2022
Merged

Conversation

antonlacon
Copy link
Contributor

This adds a one minute pause when mounting iSCSI devices during busybox's init to present a deprecation notice.

My understanding from past discussion is no one within LE uses iSCSI and consensus was to remove this feature in a future release. This PR is meant to either encourage people to move off iSCSI prior to its outright removal in LE11 (or later), or to have someone that uses iSCSI step up to maintain it.

@CvH
Copy link
Member

CvH commented Apr 9, 2022

tbh I would rather remove it directly, this nag screen is still too easy to ignore :)

Signed-off-by: Ian Leonard <antonlacon@gmail.com>
@antonlacon
Copy link
Contributor Author

This is changed to toggle LE's iscsi support to no. This disables iscsi support in the kernel and the inclusion of open-iscsi:init.

If someone shows up to maintain it, it should be easiest to 'undo' this way. Otherwise, the code behind it may be removed at a later date.

@antonlacon antonlacon changed the title busybox: init: add iscsi deprecation notice distro: disable mounting iscsi support Apr 17, 2022
@antonlacon antonlacon changed the title distro: disable mounting iscsi support distro: disable iscsi support Apr 17, 2022
@CvH CvH merged commit 36cfd54 into LibreELEC:master Apr 17, 2022
@antonlacon antonlacon deleted the iscsi-deprecation branch May 1, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants