Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: add missing 4.7.x options #748

Merged
merged 1 commit into from Sep 19, 2016
Merged

linux: add missing 4.7.x options #748

merged 1 commit into from Sep 19, 2016

Conversation

MilhouseVH
Copy link
Contributor

These are required by the latest kernel bump, although I've been building fine without them (clean x2) some people need them. All defaults.

@lrusak: Virtual is a copy of Generic, not sure if you need anything different in Virtual.

@piotrasd
Copy link
Contributor

CONFIG_PINCTRL_BAYTRAIL=y
(this becuase some Wifi are connected over SDIO/GPIO)
and
CONFIG_EFI_MIXED=y
for future support UEFI32 bootloader

@MilhouseVH
Copy link
Contributor Author

@piotrasd: updated.

@piotrasd
Copy link
Contributor

@MilhouseVH thx. i have ready version for UEFI32 but for now is ugly :/ i must little more polish

@stefansaraev
Copy link
Contributor

stefansaraev commented Sep 19, 2016

in the past, CONFIG_EFI_MIXED was known to cause boot failures on some 64bit uefi configurations. no idea if this is still an issue (things may have changed in the meantime), and I dont remember the exact boards.

EDIT: at least zotac nano aq01 failed. I have one on the shelf. (assuming it still works after sitting idle for ... 2 years) I dont mind testing it for you if you share an image.

@piotrasd
Copy link
Contributor

piotrasd commented Sep 19, 2016

i checked few devices ... and was fine. We will see if someone raport after test @MilhouseVH nightly build. Without this is no possible boot normal LE version on devices with UEFI32

@MilhouseVH
Copy link
Contributor Author

I've tested a Skylake NUC (UEFI) and Revo3700 (legacy BIOS), both booted OK.

@stefansaraev I'll get you an img.gz ASAP - will take a bout 30-40 minutes.

@MilhouseVH
Copy link
Contributor Author

@stefansaraev
Copy link
Contributor

all good. boots fine on that stone old zotac box.

@MilhouseVH
Copy link
Contributor Author

Thanks - probably best to let this bake for a couple of days and if no problems then merge.

@lrusak
Copy link
Member

lrusak commented Sep 19, 2016

would be nice to get this merged ASAP, so if there are options you aren't sure about I would split them out into another PR. Otherwise jenkins and things will fail without default options set.

@MilhouseVH
Copy link
Contributor Author

OK hang on.

@MilhouseVH
Copy link
Contributor Author

Back to 100% defaults. I'll create another PR for the two new options.

@lrusak
Copy link
Member

lrusak commented Sep 19, 2016

Yep works, thanks.

@lrusak lrusak merged commit ef0f30a into LibreELEC:master Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants