Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service.nextpvr fix broken download script #7545

Merged
merged 1 commit into from Feb 26, 2023
Merged

Conversation

emveepee
Copy link
Contributor

Not sure what happened but the script I submitted and had it locally in my repo and on GithHb had this change after CvH noted it during the PR review but it didn't make it to the PR.

@antonlacon
Copy link
Contributor

The commit message (not just the PR title) should be something like nextpvr: fix broken download script so this may be understood when reading the changelog.

@emveepee
Copy link
Contributor Author

emveepee commented Feb 26, 2023

Sorry, of course it should.

@emveepee emveepee changed the title Fix broken download script service.nextpvr fix broken download script Feb 26, 2023
@antonlacon
Copy link
Contributor

That was the PR title. The commit message needs it too. git commit --amend while on that branch to edit the last commit's message. The first line will end up as the subject which needs the change.

Not sure what happened but the script I submitted and had it locally in my repo and on GithHb had this change after CvH noted it during the  PR review but it didn't make it to the PR.
@CvH CvH merged commit fde7213 into LibreELEC:master Feb 26, 2023
@emveepee emveepee deleted the novalues branch May 25, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants