Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcdd: initial addon #837

Merged
merged 3 commits into from
Oct 27, 2016
Merged

lcdd: initial addon #837

merged 3 commits into from
Oct 27, 2016

Conversation

awiouy
Copy link
Collaborator

@awiouy awiouy commented Oct 14, 2016

LCDproc as an addon.
I am not sure to have included all required drivers

@lrusak
Copy link
Member

lrusak commented Oct 14, 2016

might as well build all drivers if it is being built as an addon

PKG_CONFIGURE_OPTS_TARGET="--with-ft-prefix=$SYSROOT_PREFIX/usr \
                           --enable-libusb \
                           --enable-libftdi \
                           --disable-libX11 \
                           --enable-libhid \
                           --disable-libpng \
                           --enable-drivers=all \
                           --enable-seamless-hbars"

also, it would be nice to dynamically list the drivers into the settings.xml

cat $ROOT/$PKG_BUILD/.$TARGET_NAME/config.log | sed -n "s|^DRIVERS=' \(.*\)'|\1|p" | sed "s|.so||g"

will list the drivers that are being built

@awiouy
Copy link
Collaborator Author

awiouy commented Oct 14, 2016

Rebased:

  • builds all drivers
  • drivers in settings are updated at build time

@lrusak
Copy link
Member

lrusak commented Oct 14, 2016

LGTM

@awiouy awiouy force-pushed the lcdd branch 2 times, most recently from f3651c3 to b817ea2 Compare October 15, 2016 04:40
@awiouy
Copy link
Collaborator Author

awiouy commented Oct 15, 2016

Rebased:

  • removed built-in lcdproc
  • updated PKG_ARCH="any"

Thank you @lrusak

@lrusak
Copy link
Member

lrusak commented Oct 15, 2016

Perfect! I'm happy with this.

along with LibreELEC/service.libreelec.settings#33 should be everything.

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Oct 15, 2016

Can I make a suggestion for the LCD driver settings - instead of a spinner, can you make it a list? Kodi are getting rid of spinners where there's a lot of options available.

Example: xbmc/xbmc#8644

@awiouy
Copy link
Collaborator Author

awiouy commented Oct 15, 2016

Rebased:
use select/values instead of labelenum/lvalues

@lrusak
Copy link
Member

lrusak commented Oct 19, 2016

a couple issues,

Could not open driver module /storage/.kodi/addons/service.lcdd/lib/l: libserdisp.so.1: cannot open shared object file: No such file or directory

and

Could not open driver module /storage/.kodi/addons/service.lcdd/lib/l: /storage/.kodi/addons/service.lcdd/lib/lcdproc/curses.so: undefined symbol: cur_term

so just disable curses driver

@awiouy
Copy link
Collaborator Author

awiouy commented Oct 21, 2016

Rebased to add icon, curses and libserdisp
Will request testing on forum

@awiouy
Copy link
Collaborator Author

awiouy commented Oct 21, 2016

Rebased to rename patches from lcdproc to lcdd :facepalm

@lrusak
Copy link
Member

lrusak commented Oct 23, 2016

all good? @awiouy please update the commit dates and we can merge

@MilhouseVH
Copy link
Contributor

There was a discussion on Slack (or was it the forum?) about the changing location of the lcdproc config (was /storage/.config, now .kodi/userdata/addon_data etc.) which is going to cause problems/confusion for existing users. Does anyone want to address the migration issues?

@awiouy
Copy link
Collaborator Author

awiouy commented Oct 23, 2016

Posted on the forum: 2 downloads, 0 feedback.
Rebased on master.

@lrusak
Copy link
Member

lrusak commented Oct 23, 2016

@MilhouseVH so basically you want to migrate so that it detects the driver user were using? and copy the relevant LCDd.conf? I'm not sure if this matters because they have to install the add-on anyway, it shouldn't be a big deal to select the driver they want to use.

@MilhouseVH
Copy link
Contributor

@lrusak: http://forum.kodi.tv/showthread.php?tid=269814&pid=2437858#pid2437858

Users seem to have to manually edit a config, so migrating the existing config would make the transition easier, alternatively using the existing config instead of changing the location would make migration unnecessary.

Just mentioning it prior to merge, as it will cause noise that could be avoided.

@awiouy
Copy link
Collaborator Author

awiouy commented Oct 23, 2016

Like this?

@lrusak
Copy link
Member

lrusak commented Oct 23, 2016

looks good to me

@awiouy
Copy link
Collaborator Author

awiouy commented Oct 23, 2016

Rebased.

@awiouy
Copy link
Collaborator Author

awiouy commented Oct 25, 2016

6 downloads in the forum, no feedback.
No news, good news?
Ready to merge,

@chewitt chewitt merged commit 161b793 into LibreELEC:master Oct 27, 2016
@camelreef
Copy link

Hello,

I switched from the 8.0 addon zip provided by Milhouse to the 8.0.100 in the repo, and it's running fine.

Thanks!

@awiouy awiouy deleted the lcdd branch October 28, 2016 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants