-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lcdd: initial addon #837
lcdd: initial addon #837
Conversation
might as well build all drivers if it is being built as an addon
also, it would be nice to dynamically list the drivers into the settings.xml
will list the drivers that are being built |
Rebased:
|
LGTM |
f3651c3
to
b817ea2
Compare
Rebased:
Thank you @lrusak |
Perfect! I'm happy with this. along with LibreELEC/service.libreelec.settings#33 should be everything. |
Can I make a suggestion for the LCD driver settings - instead of a spinner, can you make it a list? Kodi are getting rid of spinners where there's a lot of options available. Example: xbmc/xbmc#8644 |
Rebased: |
a couple issues,
and
so just disable curses driver |
Rebased to add icon, curses and libserdisp |
Rebased to rename patches from lcdproc to lcdd :facepalm |
all good? @awiouy please update the commit dates and we can merge |
There was a discussion on Slack (or was it the forum?) about the changing location of the lcdproc config (was /storage/.config, now .kodi/userdata/addon_data etc.) which is going to cause problems/confusion for existing users. Does anyone want to address the migration issues? |
Posted on the forum: 2 downloads, 0 feedback. |
@MilhouseVH so basically you want to migrate so that it detects the driver user were using? and copy the relevant LCDd.conf? I'm not sure if this matters because they have to install the add-on anyway, it shouldn't be a big deal to select the driver they want to use. |
@lrusak: http://forum.kodi.tv/showthread.php?tid=269814&pid=2437858#pid2437858 Users seem to have to manually edit a config, so migrating the existing config would make the transition easier, alternatively using the existing config instead of changing the location would make migration unnecessary. Just mentioning it prior to merge, as it will cause noise that could be avoided. |
Like this? |
looks good to me |
Rebased. |
6 downloads in the forum, no feedback. |
Hello, I switched from the 8.0 addon zip provided by Milhouse to the 8.0.100 in the repo, and it's running fine. Thanks! |
LCDproc as an addon.
I am not sure to have included all required drivers