Replace dialog with whiptail #854
Conversation
Include UTF-8 charmap and compress it.
newt/whiptail replaces dialog that is used for the installer
This modifies the installer to use whiptail instead of dialog. Line drawing does not work without a proper locale. Create en_US.UTF-8 locale as part of the installer.
|
Wow! Thanks! I'll have a look at this in more detail later. |
| @@ -634,20 +635,29 @@ do_poweroff() { | |||
| } | |||
|
|
|||
| # setup needed variables | |||
| INSTALLER_VERSION="0.2.8" | |||
| INSTALLER_VERSION="0.3.0" | |||
There was a problem hiding this comment.
I think we can remove mention of installer version and only show release version.
There was a problem hiding this comment.
Ok, let's do that. I think there's a lot of room for improvement even in this text based installer (change some text, ditch the repair/upgrade mode that does not even work on my system for some reason, etc), but maybe that takes a bit more discussion...
There was a problem hiding this comment.
@trsqr feel free to make another PR with improvements that you see fit for the installer. I'd rather stuff just get done/fixed rather than having long discussions about it 👍 Keep up the great work
| msg_progress_install "97" "unmount $TMPDIR/part2" | ||
| umount $TMPDIR/part2 >> $LOGFILE 2>&1 | ||
| # umount system partition, remove mountpoint | ||
| msg_progress_install "97" " bbUnmount $TMPDIR/part2" |
There was a problem hiding this comment.
is bbUnmount formatting or a typo?
There was a problem hiding this comment.
Certainly a typo. I'll fix that later today.
Fix a typo, get rid of installer version variable and change the URL to point to the correct LibreELEC URL.
Installer needs a proper charmap. Only Generic project utilizes the installer.
Remove the (at least on my system) broken repair/upgrade mode from the installer. At the same time improve the formatting/wording of some screens. Should be a bit simpler now.
Change the prompt to instruct the end user to wait for the installer instead of just "Press TAB for boot options". Hopefully more intuitive now. Rebrand to LE in the code also. :)
|
Ok, quite significant changes here now. IMHO it's much better now, even if we should explore more graphical installation options. Here's a YouTube video of the current state: Any feedback regarding the wording/color schemes/etc? |
|
Looks great! I would maybe change the magenta to one of the colours that is in our logo though. |
|
Yeah, I was looking for a nice color scheme, but couldn't really fine one. In the end I settled with the standard Ubuntu installer colors. I'm by no means a graphical designer, so I'll leave it for the others to modify the palette. It should be pretty easy now though. |
There's an ugly bug in the current dialog-based installer:
https://www.youtube.com/watch?v=vG9xAggiulg&feature=youtu.be
This replaces dialog with whiptail and adds possibility to customize the installer color palette easily by modifying installer.conf. The UTF-8 charmap was needed to enable proper line drawing.