Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluez: update to 5.75 #8820

Merged
merged 1 commit into from Apr 21, 2024
Merged

bluez: update to 5.75 #8820

merged 1 commit into from Apr 21, 2024

Conversation

heitbaum
Copy link
Contributor

@heitbaum heitbaum commented Apr 18, 2024

Attempt to address issue reported at https://forum.libreelec.tv/thread/28431-libreelec-omega-12-beta2/?postID=191001#post191001

seems to be addressed in 5.75 (with the post patch) read bluez/bluez#777 (comment) and the following 2 comments.

post ver 5.75:

  • shared/uhid: Fix crash if bt_uhid_destroy free replay structure

ver 5.75:

  • Fix issue with build system and header inclusion.

ver 5.74:

  • Fix issue with not enabling Wideband Speech when available.
  • Fix issue with UserspaceHID and Bluetooth Classic devices.
  • Fix issue with checking for services being connected.
  • Fix issue with GATT client connection creation.
  • Fix issue with OBEX and small file transfers.
  • Fix issue with handling pairing with Apple AirPods.

log:

post ver 5.75:
- shared/uhid: Fix crash if bt_uhid_destroy free replay structure

ver 5.75:
- Fix issue with build system and header inclusion.

ver 5.74:
- Fix issue with not enabling Wideband Speech when available.
- Fix issue with UserspaceHID and Bluetooth Classic devices.
- Fix issue with checking for services being connected.
- Fix issue with GATT client connection creation.
- Fix issue with OBEX and small file transfers.
- Fix issue with handling pairing with Apple AirPods.

log:
- https://git.kernel.org/pub/scm/bluetooth/bluez.git/log/
@jonian
Copy link

jonian commented Apr 21, 2024

Hi @heitbaum, I have tested the RPi5 image you provided in the forum. The controller works and the log spamming (as reported in bluez/bluez#777) has stopped but there is an issue with the controller light not turning blue.

On LE 11 (bluez 5.66) the behavior is:

  • Connect controller - Working, blue light
  • Reconnect controller - Working, blue light

On LE 12 Beta 1/2 (bluez 5.73) the behavior is:

  • Connect controller - Working, blue light
  • Reconnect controller - Not working, white light

With this MR (bluez 5.75 + patch) the behavior is:

  • Connect controller - Working, blue light
  • Reconnect controller - Working, white light

If I restart the bluetooth service and re-connect the controller it is also working and has a blue light on any LE version.

@heitbaum heitbaum marked this pull request as ready for review April 21, 2024 09:16
@heitbaum
Copy link
Contributor Author

Hi @heitbaum, I have tested the RPi5 image you provided in the forum. The controller works and the log spamming (as reported in bluez/bluez#777) has stopped but there is an issue with the controller light not turning blue.

On LE 11 (bluez 5.66) the behavior is:

  • Connect controller - Working, blue light
  • Reconnect controller - Working, blue light

On LE 12 Beta 1/2 (bluez 5.73) the behavior is:

  • Connect controller - Working, blue light
  • Reconnect controller - Not working, white light

With this MR (bluez 5.75 + patch) the behavior is:

  • Connect controller - Working, blue light
  • Reconnect controller - Working, white light

If I restart the bluetooth service and re-connect the controller it is also working and has a blue light on any LE version.

Good that it addresses the main issue. I have taken this out of draft for LE12. With regard to the white versus blue - good to see it raised with upstream 👍.

@chewitt chewitt merged commit c617f17 into LibreELEC:master Apr 21, 2024
@heitbaum heitbaum deleted the bluez branch April 21, 2024 09:44
@jonian
Copy link

jonian commented Apr 21, 2024

@heitbaum After some more searching I found bluez/bluez#804 (comment). Maybe we need a patch for the kernel too? Like this one ananjaser1211/rocknix@ff51a93 maybe.

@heitbaum
Copy link
Contributor Author

@heitbaum After some more searching I found bluez/bluez#804 (comment). Maybe we need a patch for the kernel too? Like this one ananjaser1211/rocknix@ff51a93 maybe.

That patch does not apply with the 6.6 kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants