Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

busybox: fix tar #922

Merged
merged 1 commit into from
Nov 12, 2016
Merged

busybox: fix tar #922

merged 1 commit into from
Nov 12, 2016

Conversation

awiouy
Copy link
Collaborator

@awiouy awiouy commented Nov 7, 2016

Busybox tar fails to untar some files with "bad tar magic"/"short read".
This problem also occurs on other Busybox distributions, eg Alpine, OpenWrt, etc.
I could not find a bug report/fix, only a a workaround: install tar.
There are probably other things to do, ie disable Busybox tar and install tar, but I would not know what.

@lrusak
Copy link
Member

lrusak commented Nov 7, 2016

You can add this to an add-on that needs it, but I don't think this should go in the base system

@awiouy
Copy link
Collaborator Author

awiouy commented Nov 7, 2016

If you do not mind, I will leave that here until Busybox tar is fixed.
https://bugs.busybox.net/show_bug.cgi?id=9406

@awiouy awiouy changed the title tar: initial package busybox: fix tar Nov 11, 2016
@awiouy
Copy link
Collaborator Author

awiouy commented Nov 11, 2016

Busybox provided a patch to fix tar, see bug 9406 linked above.
The patch applies and builds, needs to be runtime tested.
@MilhouseVH could you add this to your builds for testing?

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Nov 11, 2016

OK (will be in #1111)

Edit: BTW this is the commit: https://git.busybox.net/busybox/commit/?id=9655f95d0f501b03b33c7896b7b0c23d090aff81

I've tested your tar.gz file from 9406 on RPi3 with build #1111 and I'm not seeing any tar errors now, so the fix looks good. :)

@awiouy
Copy link
Collaborator Author

awiouy commented Nov 12, 2016

Cool, thank you for having tested.
Ready to merge

@chewitt chewitt merged commit eb2d020 into LibreELEC:master Nov 12, 2016
@CvH CvH added the BUGFIX label Nov 17, 2016
@awiouy awiouy deleted the tar branch December 5, 2016 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants