samba: fix allocation/size on disk issues reported by Windows 8.x+ #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MilhouseVH has there been and positive/negative feedback from your builds? |
|
No feedback at all, which is good. I'm in no rush to merge this unless you are - could merge along with Kodi 17 b6, giving a little more time for any samba issues to creep their way out of the woodwork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://forum.libreelec.tv/thread-2485.html, which should be fixed by adding
allocation roundup size = 0.I've also added
strict allocate = yesas this may improve performance (https://wiki.samba.org/index.php/Linux_Performance).I'd like about a week of test builds without any incident before merging this, so keep open.