Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samba: fix allocation/size on disk issues reported by Windows 8.x+ #951

Merged
merged 1 commit into from Nov 29, 2016

Conversation

@MilhouseVH
Copy link
Contributor

commented Nov 18, 2016

See: https://forum.libreelec.tv/thread-2485.html, which should be fixed by adding allocation roundup size = 0.

I've also added strict allocate = yes as this may improve performance (https://wiki.samba.org/index.php/Linux_Performance).

I'd like about a week of test builds without any incident before merging this, so keep open.

@chewitt

This comment has been minimized.

Copy link
Member

commented Nov 22, 2016

@MilhouseVH has there been and positive/negative feedback from your builds?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2016

No feedback at all, which is good. I'm in no rush to merge this unless you are - could merge along with Kodi 17 b6, giving a little more time for any samba issues to creep their way out of the woodwork.

@MilhouseVH MilhouseVH removed the Keep Open label Nov 27, 2016

@chewitt chewitt merged commit a26112d into LibreELEC:master Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.