Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODROID C2: Fix usb/dwc_otg #62

Merged
merged 2 commits into from
Oct 24, 2017
Merged

Conversation

wrxtasy
Copy link
Contributor

@wrxtasy wrxtasy commented Oct 17, 2017

Problems with C2 USB HID attached devices are shown as errors in the Kernel log:

[ 5.737077@1] Bluetooth: Core ver 2.18
[ 5.737132@1] NET: Registered protocol family 31
[ 5.737136@1] Bluetooth: HCI device and connection manager initialized
[ 5.737162@1] Bluetooth: HCI socket layer initialized
[ 5.737170@1] Bluetooth: L2CAP socket layer initialized
[ 5.737201@1] Bluetooth: SCO socket layer initialized
[ 5.750594@0] usbcore: registered new interface driver btusb
[ 5.888840@0] ERROR::handle_hc_nak_intr:1306: Can not read device info from hub.We take it error
[ 5.888840@0]
[ 5.953043@2] input: lircd-uinput as /devices/virtual/input/input8
[ 6.091726@0] 8021q: 802.1Q VLAN Support v1.8

Solution was to pull in some Hardkernel commits to fix USB Hub HID issues.

On the C2 this also allows BT USB HID devices like the Xiaomi Mi Box remote (with further LE patching) and the PS3 USB connected controllers to work properly.

The Lakka guys will likely be interested in USB controllers working.

Also required as a Kernel Config:

@@ -2720,7 +2719,7 @@
 CONFIG_HID=y
 # CONFIG_HID_BATTERY_STRENGTH is not set
 CONFIG_HIDRAW=y
-# CONFIG_UHID is not set
+CONFIG_UHID=y
 CONFIG_HID_GENERIC=y

Tested only on the C2, further testing required on the WeTek Hub / Play2

ping @Raybuntu @kszaq @codesnake

@wrxtasy wrxtasy changed the title ODROID C2: Fix dwc_otg ODROID C2: Fix usb/dwc_otg Oct 17, 2017
@stefansaraev
Copy link

stefansaraev commented Oct 17, 2017

meh on wetek play 2

without adjusting gxbb_p200_2G_wetek_play_2.dts - usb hid connected to side usb port not recognised
with adjusted gxbb_p200_2G_wetek_play_2.dts: http://sprunge.us/OLXb

@wrxtasy
Copy link
Contributor Author

wrxtasy commented Oct 17, 2017

Thx.
It may just be easier to throw the C2 specific Linux patches in their own LE C2 project folder otherwise headaches are likely going forward.

@Ray-future
Copy link
Contributor

Ray-future commented Oct 17, 2017

Thank you @wrxtasy for submitting this PR. I will do some tests the next few days. I'd like to not use a project specific patch for C2 only. Especially with all those Retroplayer changes coming in LE9/Kodi 18 people are gonna want their controllers to work on WP2 too.

EDIT: I just understood that it's just a C2 issue. Sorry for the confusion. A project specific patch might be a solution too.

ckkim and others added 2 commits October 19, 2017 11:18
Change-Id: Ie19321c46aacea48d1b06d9e55dcafa5477dc33f
Change-Id: I8954cb189b1c88f70d9d997d92e953e6455b18fd
@wrxtasy
Copy link
Contributor Author

wrxtasy commented Oct 19, 2017

Dumped the problematic Hardkernel dwc_otg revert.

Tested on C2 and WeTek Hub with:

USB HID - Sony PLAYSTATION(R)3 Controller and
C2 - USB BT - HID Xiaomi Mi Box remote

and no regressions this time with the Hub.
Will submit a further LE PR for correct UHID Kernel configs

Copy link
Contributor

@Ray-future Ray-future left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick test shows no more issues on WP2. I'll put it in my builds today and see if there are any issues reported.

@wrxtasy
Copy link
Contributor Author

wrxtasy commented Oct 19, 2017

Good news.
Will have to look into some Kodi Retro gaming next - now my old PS3 controllers work ! 👍

@Ray-future Ray-future merged commit fb3d02c into LibreELEC:amlogic-3.14.y Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants