Properly fix duplicate bluetooth devices #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad10135.
C-Prime90
force-pushed
the
proper-bluetooth-fix
branch
2 times, most recently
from
bd3cbde
to
b13c96e
Compare
|
I'll include this PR in my nightly test builds, let's see how it goes for a few days before merging. |
|
Thanks for testing, I found a case where duplicates can still happen and it made me take a different approach i feel is a better solution, i will be updating PR once i am satisfied so you can test it out. Issue - If add-on is left open for a very long time duplicates can happen. Upon realizing what is actually happening i have made it so listItems is not checked and list is rebuilt every time menu_connections() is called if any device is found, everything seems to be working well now i can't manage to create any duplicates with new commit. |
C-Prime90
force-pushed
the
proper-bluetooth-fix
branch
from
b13c96e
to
71edd4c
Compare
|
I am done with this PR now, any issues with it please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the previous PR #124 and properly fixes the bluetooth issue.
sorry guys i missed the fact i broke stuff but i have fixed it properly now.