Remove Estuary specific elements #130
Conversation
|
Is this ready to go in now? |
|
This can go in - just keep in mind that it takes away the top bar in the LE settings since that bar doesn't exist in other skins. It's the breadcrumbs and clock bar - so technically, it just gives an error on other skins, but I don't believe it causes any problems if we don't change it. The Kodi team didn't want to add the conditional variable for skin name - so the only option left was to take out the Estuary specific calls to the top/bottom bars. |
|
It would be better to rename this PR and squash the commits before we merge it as the PR description no longer accurately describes what is happening here - the first commit did add conditional Estuary calls, but these were then removed by the second commit. Ultimately this entire PR seems to be removing the breadcrumb labels and (no longer) has anything to do with Estuary or conditionals. If you can update the description and squash the commits I'll merge this so we can get it into master and also |
While this removes the breadcumbs and clock bar when running the addon - it should make it universally compatible with all skins without generating log errors. fix background path
edit4ever
force-pushed
the
skin_incompatibility
branch
from
b7467fa
to
249496f
Compare
edit4ever
changed the title
|
done. :-) |
|
Thanks! |
No description provided.