allow using custom update channels

[lrusak]

should be good to go, let me know if the strings make sense.

[MilhouseVH]

Something weird is going on when you cancel the Automatic Updates, Update Channel and Available Versions dialogs. Open these dialogs and then click Cancel (or back - you may need to repeat this a second time).

It looks like the System panel is being refreshed, and half of the time the focus is being "lost", returning to the main menu, ie. click on Update Channel, click cancel, click down and (half of the time) instead of the focus moving to Available Versions as expected, instead you move from System to Network...

[MilhouseVH]

This is loading the url a second time if it worked the first time, doubling the network overhead... shouldn't this be:

+                update_json = json.loads(data)

?

[lrusak]

Yep that will work better

[lrusak]

updated, I'm still not sure why the focus is being lost...

[MilhouseVH]

Thanks, updated version is working better (fewer downloads of releases.json).

However there's a problem when downloading:

22:31:52 3286.522217 T:1591735200   ERROR: ## LibreELEC Addon ## oe::download_file(http://milhouse.libreelec.tv/builds/master/RPi2/LibreELEC-RPi2.arm-8.0-Milhouse-20160613210617-#0613-g64949dd.tar, /storage/.kodi/temp/LibreELEC-RPi2.arm-8.0-Milhouse-20160613210617-#0613-g64949dd.tar) ## ERROR: (HTTPError())
22:31:52 3286.522949 T:1591735200   ERROR: Traceback (most recent call last):
                                              File "/home/neil/projects/LibreELEC.tv/build.LibreELEC-RPi2.arm-8.0-devel/LibreELEC-settings-168c183/.install_pkg/usr/share/kodi/addons/service.libreelec.settings/oe.py", line 284, in download_file
                                              File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
                                              File "/usr/lib/python2.7/urllib2.py", line 437, in open
                                              File "/usr/lib/python2.7/urllib2.py", line 550, in http_response
                                              File "/usr/lib/python2.7/urllib2.py", line 475, in error
                                              File "/usr/lib/python2.7/urllib2.py", line 409, in _call_chain
                                              File "/usr/lib/python2.7/urllib2.py", line 558, in http_error_default
                                            HTTPError: HTTP Error 404: Not Found

I don't think you're escaping/quoting the url so the hash (#) isn't converted to %23.

There's also no visual indication that the download has failed - it fails silently.

[MilhouseVH]

It also looks like it has created the download file in /storage/.kodi/temp which makes me wonder if the temp folder could slowly become full of partially downloaded .tar files. Maybe a better solution would be to use a single filename for the temp file thus overwriting any existing temp file, then use the correct download filename when copying to /storage/.update. This way you'd only have at most one tar file hanging around in the temp folder.

[lrusak]

@MilhouseVH I updated this, it should now work properly if the user has no internet connection or if they input the wrong url.